fix: clean up dead Temporal operations.go stubs #35

2026-09-26T10:08:01Z

rock commented

2026-09-26 10:08:01 +00:00

Summary

Delete operations.go (95 LOC TODO stubs, never called)
Refactor handler.go to delegate 8 gRPC operations to WorkflowGRPCImpl/SearchAttributesGRPCImpl
Remove unused imports
Net -109 lines

Verification

go build ./... PASS
go vet ./internal/temporal/... PASS
No behavior change for API consumers
5 methods upgraded from fake/TODO data to real gRPC calls

Closes #31

## Summary - Delete `operations.go` (95 LOC TODO stubs, never called) - Refactor `handler.go` to delegate 8 gRPC operations to `WorkflowGRPCImpl`/`SearchAttributesGRPCImpl` - Remove unused imports - Net -109 lines ## Verification - `go build ./...` PASS - `go vet ./internal/temporal/...` PASS - No behavior change for API consumers - 5 methods upgraded from fake/TODO data to real gRPC calls Closes #31

rock added 1 commit 2026-09-26 10:18:41 +00:00

fix: clean up dead Temporal operations.go stubs (#31 )

CI / CI (pull_request) Canceled after 0s

Details

a86c22fba8

- Delete operations.go (TODO stubs, never called by handler.go)
- Refactor handler.go: 8 methods delegate to WorkflowGRPCImpl/SearchAttributesGRPCImpl
- Remove unused query/v1 import
- Remaining inline methods kept (reset, update, activity, namespace, cluster ops)
- No behavior change in API responses

Closes #31

rock force-pushed fix/cleanup-temporal-operations from d79b434880 to a86c22fba8

2026-09-26 10:18:41 +00:00

Compare

rock closed this pull request

2026-09-26 10:57:48 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: riotpiao-poimen/homelab-frontend#35