## Problem Monolithic test-build-push job runs all steps sequentially, with conditionals for push only on main. This makes it hard to see what failed and doesn't clearly separate concerns. ## Fix Split into two jobs: - **test**: Runs on all branches + PRs (go mod, vet, test, build binary) - **build-push**: Runs only on main push after test passes Move env vars to workflow level (cleaner, reused by both jobs). ## Result - PRs: test job runs ✅ (no docker install, no registry push) ✅ - Main push: test → build-push → registry push ✅ --------- Co-authored-by: Test <[email protected]> Reviewed-on: #3
67 lines
1.7 KiB
YAML
67 lines
1.7 KiB
YAML
name: CI
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
pull_request:
|
|
branches: [main]
|
|
|
|
env:
|
|
GOPRIVATE: forgejo.riotpiao.com
|
|
REGISTRY: forgejo.riotpiao.com
|
|
IMAGE: forgejo.riotpiao.com/rock/poimen-workflows
|
|
|
|
jobs:
|
|
test:
|
|
name: Test
|
|
runs-on: golang
|
|
steps:
|
|
- name: Install Node.js for actions runtime
|
|
run: apt-get update && apt-get install -y nodejs
|
|
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Download dependencies
|
|
run: go mod download
|
|
|
|
- name: Vet
|
|
run: go vet ./...
|
|
|
|
- name: Test
|
|
run: go test ./...
|
|
|
|
- name: Build binary
|
|
run: CGO_ENABLED=0 GOOS=linux go build -o /tmp/poimen-worker ./cmd/worker
|
|
|
|
build-push:
|
|
name: Build & Push Image
|
|
needs: test
|
|
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
|
|
runs-on: golang
|
|
steps:
|
|
- name: Install Node.js and Docker
|
|
run: apt-get update && apt-get install -y nodejs docker.io
|
|
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Get short SHA
|
|
id: sha
|
|
run: echo "short_sha=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
|
|
|
|
- name: Registry login
|
|
run: |
|
|
echo "${{ secrets.FORGEJO_REGISTRY_TOKEN }}" | docker login "${REGISTRY}" \
|
|
--username "${{ secrets.FORGEJO_REGISTRY_USER }}" --password-stdin
|
|
|
|
- name: Build and push image
|
|
run: |
|
|
docker build \
|
|
-t "${IMAGE}:${{ steps.sha.outputs.short_sha }}" \
|
|
-t "${IMAGE}:latest" \
|
|
.
|
|
docker push "${IMAGE}:${{ steps.sha.outputs.short_sha }}"
|
|
docker push "${IMAGE}:latest"
|
|
echo "✓ Pushed ${IMAGE}:${{ steps.sha.outputs.short_sha }}"
|