fix: memory service CI + unified workflow pattern #18

2026-09-07T06:27:37Z

rock commented

2026-09-07 06:27:37 +00:00

Problem

PR #16 (security & integration hardening) had an outdated CI workflow that conflicted with the unified pattern deployed to main.

Solution

Rebased PR #16 from main, resolved workflow conflict by keeping the unified pattern:

test job: all branches + PRs (cargo test/check)
build-push job: main push only (docker build + push)
Install Node.js before checkout
Proper secrets and env handling

Code Changes

All security & integration improvements from original PR #16 are preserved:

Temporal filtering (semantic_retriever.rs)
Answer validation (query_router.rs)
GRM context integration (fact_extractor.rs, ingest_pipeline.rs)
Speaker extraction (entity_extractor.rs)
Memorability gate (memorability_gate.rs)
Community metrics (community_metrics.rs)
Answer validator (answer_validator.rs)

CI Workflow

Updated to match unified pattern (same as riotpiao.com, homelab-frontend, Poimen workflows):

✅ test: all branches + PRs
✅ build-push: main push only
✅ Install Node.js before checkout
✅ Docker only in build-push
✅ Proper secrets (FORGEJO_REGISTRY_USER, TOKEN)
✅ Docker login → build → push → prune

## Problem PR #16 (security & integration hardening) had an outdated CI workflow that conflicted with the unified pattern deployed to main. ## Solution Rebased PR #16 from main, resolved workflow conflict by keeping the unified pattern: - test job: all branches + PRs (cargo test/check) - build-push job: main push only (docker build + push) - Install Node.js before checkout - Proper secrets and env handling ## Code Changes All security & integration improvements from original PR #16 are preserved: - Temporal filtering (semantic_retriever.rs) - Answer validation (query_router.rs) - GRM context integration (fact_extractor.rs, ingest_pipeline.rs) - Speaker extraction (entity_extractor.rs) - Memorability gate (memorability_gate.rs) - Community metrics (community_metrics.rs) - Answer validator (answer_validator.rs) ## CI Workflow Updated to match unified pattern (same as riotpiao.com, homelab-frontend, Poimen workflows): - ✅ test: all branches + PRs - ✅ build-push: main push only - ✅ Install Node.js before checkout - ✅ Docker only in build-push - ✅ Proper secrets (FORGEJO_REGISTRY_USER, TOKEN) - ✅ Docker login → build → push → prune

rock added 1 commit 2026-09-07 06:27:38 +00:00

fix: security & integration hardening + unified CI workflow

CI / Test (pull_request) Successful in 2m7s

Details

CI / Build & Push Image (pull_request) Skipped

Details

7a2a0df490

## Code Changes (from original PR #16)

Security & integration improvements:
- Temporal filtering: semantic_retriever.rs (fact_invalid_at, event_time)
- Answer validation: query_router.rs (6-signal multi-signal validation)
- GRM context → facts: fact_extractor.rs + ingest_pipeline.rs
- Speaker extraction first: entity_extractor.rs (Zep alignment)
- Memorability gate: memorability_gate.rs
- Community metrics: community_metrics.rs
- Answer validator: answer_validator.rs

## CI Workflow (unified pattern from main)

Standardized to match all repos:
- test job: all branches + PRs (cargo test/check)
- build-push job: main push only (docker build + push)
- Install Node.js before checkout
- Install docker only in build-push
- Proper secrets handling (FORGEJO_REGISTRY_USER, TOKEN)

rock closed this pull request

2026-09-07 06:30:44 +00:00

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: rock/poimen-memory#18