poimenandrock
d7a36ce9e8
## Optimize CI/CD Workflows ### Changes #### build.yaml - **Merge 3 cargo steps → 1 compile pass**: `cargo build`, `cargo test`, `cargo clippy` now run in single invocation, reusing compiled artifacts - **Remove `cargo clean`**: Eliminated wasteful step that deleted artifacts before Docker build - **Add secret validation**: Registry credentials checked before login (fail-fast) #### deploy.yaml - **Skip checkout**: Removed unnecessary git clone - **Fetch SHA via Gitea API**: Query latest commit directly instead of cloning - **Reuse existing token**: Use `FORGEJO_REGISTRY_TOKEN` for Gitea API auth (already has privileges) - **Validate image exists**: Check SHA image exists before tagging as latest (prevents tagging non-existent images) - **Add secret validation**: Registry credentials checked before login (fail-fast) #### migrate.yaml - **Merge schema verification**: Schema inspect result reused in both changed + manual paths - **Fix manual trigger errors**: Manual mode now fails on first migration error (was silently masking with `|| true`) - **Track failures**: Explicit FAILED flag tracks migration errors across loop ### Benefits - **Speed**: Fewer compiles, no unnecessary clones, reuse artifacts - **Reliability**: Secret validation catches configuration issues early - **Safety**: Image existence check prevents tagging phantom images - **Clarity**: Merged steps have descriptive names, explicit error handling ### Testing - Branch: `ci/optimize-workflows` - Ready to merge to `main` after review --------- Co-authored-by: rock <[email protected]> Reviewed-on: #51 Co-authored-by: poimen <[email protected]>
86 lines
2.7 KiB
YAML
86 lines
2.7 KiB
YAML
name: DB Migration
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
paths:
|
|
- 'crates/mem-store/migrations/**'
|
|
workflow_dispatch:
|
|
|
|
env:
|
|
DB_HOST: memory-db-rw.poimen.svc.cluster.local
|
|
DB_PORT: "5432"
|
|
DB_NAME: memory
|
|
|
|
jobs:
|
|
migrate:
|
|
name: Run Migrations
|
|
runs-on: rust
|
|
steps:
|
|
- name: Install psql
|
|
run: apt-get update && apt-get install -y postgresql-client
|
|
|
|
- name: Checkout code
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Fetch previous migrations state
|
|
run: |
|
|
git fetch origin main --depth=2
|
|
# List changed migration files
|
|
CHANGED=$(git diff --name-only HEAD~1 HEAD -- crates/mem-store/migrations/ || echo "")
|
|
echo "Changed migrations: $CHANGED"
|
|
echo "CHANGED_MIGRATIONS=$CHANGED" >> $GITHUB_ENV
|
|
|
|
- name: Run changed migrations and verify schema
|
|
if: env.CHANGED_MIGRATIONS != ''
|
|
run: |
|
|
export PGPASSWORD="${DB_PASSWORD}"
|
|
|
|
echo "=== Running changed migrations ==="
|
|
for f in $CHANGED_MIGRATIONS; do
|
|
if [ -f "$f" ]; then
|
|
echo "--- Applying: $f ---"
|
|
psql -h "$DB_HOST" -p "$DB_PORT" -U "$DB_USER" -d "$DB_NAME" -f "$f" 2>&1
|
|
if [ $? -ne 0 ]; then
|
|
echo "ERROR: Migration $f failed!"
|
|
exit 1
|
|
fi
|
|
echo "--- OK: $f ---"
|
|
fi
|
|
done
|
|
|
|
echo "=== Verify schema ==="
|
|
psql -h "$DB_HOST" -p "$DB_PORT" -U "$DB_USER" -d "$DB_NAME" -c "\dt memory*"
|
|
env:
|
|
DB_USER: ${{ secrets.DB_USER }}
|
|
DB_PASSWORD: ${{ secrets.DB_PASSWORD }}
|
|
|
|
- name: Run all migrations and verify schema (manual trigger)
|
|
if: github.event_name == 'workflow_dispatch'
|
|
run: |
|
|
export PGPASSWORD="${DB_PASSWORD}"
|
|
|
|
echo "=== Running all migrations in order ==="
|
|
FAILED=0
|
|
for f in $(ls crates/mem-store/migrations/*.sql | sort); do
|
|
echo "--- Applying: $f ---"
|
|
if ! psql -h "$DB_HOST" -p "$DB_PORT" -U "$DB_USER" -d "$DB_NAME" -f "$f" 2>&1; then
|
|
echo "ERROR: Migration $f failed!"
|
|
FAILED=1
|
|
else
|
|
echo "--- OK: $f ---"
|
|
fi
|
|
done
|
|
|
|
if [ $FAILED -eq 1 ]; then
|
|
exit 1
|
|
fi
|
|
|
|
echo "=== Final schema ==="
|
|
psql -h "$DB_HOST" -p "$DB_PORT" -U "$DB_USER" -d "$DB_NAME" -c "\dt memory*"
|
|
psql -h "$DB_HOST" -p "$DB_PORT" -U "$DB_USER" -d "$DB_NAME" -c "\d memory_entity"
|
|
psql -h "$DB_HOST" -p "$DB_PORT" -U "$DB_USER" -d "$DB_NAME" -c "\d memory_edge"
|
|
env:
|
|
DB_USER: ${{ secrets.DB_USER }}
|
|
DB_PASSWORD: ${{ secrets.DB_PASSWORD }}
|