fix: Dockerfile uses rust:1-bookworm, build mem-cli binary #26

Merged

rock merged 4 commits from fix/dockerfile into main 2026-09-08 01:11:17 +00:00

Conversation 0 Commits 4 Files Changed 47

+736 -122

rock commented 2026-09-07 20:39:02 +00:00

Owner

Copy Link

Copy Source

Summary

Dockerfile and CI fixes for production builds - WITH COMPILATION ERRORS TO FIX

⚠️ STATUS: PR includes good changes (Dockerfile + unified CI) but mem-cli has unresolved compilation errors blocking merge.

Problem Statement

Before:

• ❌ Dockerfile referenced non-existent rust:1.81 image tag
• ❌ sqlx tried to connect to DB at build time
• ❌ Separate test + build jobs
• ❌ CI only tested mem-ingest (missed mem-cli errors)

Now:
✅ Dockerfile fixed
✅ CI tests ALL packages
❌ NEW ISSUE: mem-cli fails to compile (29 errors)

What Was Fixed

1. ✅ Dockerfile: rust:1-bookworm + SQLX_OFFLINE

File: Dockerfile

• FROM rust:1-bookworm (stable)
• ENV SQLX_OFFLINE=true (use offline cache)
• RUN cargo build --release -p mem-cli

2. ✅ .sqlx/ Query Cache (Checked In)

Files: .sqlx/*.json (5 compiled queries)

• Enables offline sqlx builds
• Prevents DB connection at build time

3. ✅ Borrow Checker Fixes: versioning.rs

File: crates/mem-store/src/versioning.rs

• 36 lines refactored
• No overlapping borrows
• 0 borrow checker errors ✓

4. ✅ Unified CI Workflow (IMPROVED)

File: .gitea/workflows/build.yaml - Latest commit (08b2c44)

• ✅ Build all packages: cargo build --all
• ✅ Test all packages: cargo test --all --lib
• ✅ Clippy linting (catches compile-time errors)
• ✅ Docker build/push only on push/dispatch (not PR)

❌ Compilation Errors (MUST FIX)

Running cargo test --all --lib reveals 29 errors in mem-cli:

Group 1: Missing sqlx cache (2 errors)

error: set `DATABASE_URL` or run `cargo sqlx prepare`
  → crates/mem-cli/src/handlers/rebuild_handler.rs:196 (SELECT id FROM memory_entity)
  → crates/mem-cli/src/handlers/rebuild_handler.rs:208 (SELECT id FROM memory_edge)

Fix: Run against live DB to generate cache

DATABASE_URL=postgresql://... cargo sqlx prepare -p mem-cli

Group 2: Missing imports/modules (11 errors)

error[E0432]: unresolved import `crate::auth`
  → versioning_handler.rs, ranking_handler.rs, rebuild_handler.rs
  
error[E0432]: unresolved import `mem_store::db_repo`
  → ingest_with_persistence.rs
  
error[E0432]: unresolved import `crate::agent::DefaultAgent`
  → agent_handler.rs
  
error[E0432]: unresolved import `crate::answer_validator`
  → query_router.rs

Fix: Add missing modules to lib.rs exports

Group 3: Missing dependencies (2 errors)

error[E0433]: cannot find `futures_util`
  → visualize_sse.rs (StreamExt)
  
error[E0433]: cannot find `async_stream`
  → visualize_sse.rs (async_stream::stream!)
  
error[E0433]: cannot find `rand`
  → agent/webhook_handler.rs

Fix: Add to Cargo.toml

futures-util = "0.3"
async-stream = "0.3"
rand = "0.8"

Group 4: Missing types (7 errors)

error[E0425]: cannot find type `AppState`
  → unified_synthesis.rs, agent_handler.rs (5 occurrences)
  
error[E0425]: cannot find function `unauthorized`
  → unified_synthesis.rs, agent_handler.rs (response_builder::unauthorized)
  
error[E0106]: missing lifetime specifier
  → community_metrics.rs:208 (fn with &[CommunityMetrics])

Fix:

• Define AppState in main.rs or lib.rs
• Add unauthorized() to response_builder module
• Add lifetime to community_metrics function signature

Group 5: Missing handler registrations (3 errors)

error[E0425]: cannot find `visualize_handler`
  → http_server.rs:413
  
error[E0425]: cannot find `visualize_stream_handler`
  → http_server.rs:414
  
error[E0425]: cannot find `compact_handler`
  → http_server.rs:415

Fix: Import handlers in http_server.rs

use crate::handlers::{visualize_handler, visualize_stream_handler, compact_handler};

Test Results

✅ mem-ingest: 81/81 tests passing

test result: ok. 81 passed; 0 failed

❌ mem-cli: 29 compilation errors (blocking)

❌ mem-store: Blocked by mem-cli errors

❌ mem-core: Not yet tested (likely blocked)

What to Do

Option A: Merge as-is (NOT RECOMMENDED)

• Dockerfile is correct ✓
• CI workflow is good ✓
• But CI will FAIL when running on main (mem-cli won't compile)

Option B: Fix errors before merge (RECOMMENDED)

1. Generate missing sqlx cache:

   export DATABASE_URL=postgresql://...
   cargo sqlx prepare -p mem-cli
   git add .sqlx/
   git commit -m "chore: update sqlx cache for rebuild_handler queries"
   

2. Add missing modules to lib.rs:

   • mem-store: export db_repo
   • mem-cli: export auth, answer_validator, agent::DefaultAgent

3. Add missing dependencies:

   • futures-util, async-stream, rand in Cargo.toml

4. Fix type definitions:

   • Define AppState in main.rs
   • Add unauthorized() to response_builder
   • Fix lifetime in community_metrics

5. Register handlers:

   • Import handlers in http_server.rs
   • Wire routes in main()

6. Verify compilation:

   cargo test --all --lib
   cargo build --all
   

Files to Check

• ❌ crates/mem-cli/src/lib.rs (export missing modules)
• ❌ crates/mem-cli/src/main.rs (define AppState, register handlers)
• ❌ crates/mem-cli/src/response_builder.rs (add unauthorized())
• ❌ crates/mem-cli/src/query/community_metrics.rs (fix lifetime)
• ❌ crates/mem-cli/Cargo.toml (add futures-util, async-stream, rand)
• ❌ crates/mem-cli/src/handlers/rebuild_handler.rs (needs sqlx cache)
• ✅ Dockerfile (correct)
• ✅ .gitea/workflows/build.yaml (correct)
• ✅ crates/mem-store/src/versioning.rs (correct)

Recommendation

DO NOT MERGE until all 29 errors are fixed. The Dockerfile changes are good, but CI will fail on the build stage because mem-cli won't compile.

## Summary Dockerfile and CI fixes for production builds - **WITH COMPILATION ERRORS TO FIX** ⚠️ **STATUS**: PR includes good changes (Dockerfile + unified CI) but mem-cli has unresolved compilation errors blocking merge. ## Problem Statement **Before**: - ❌ Dockerfile referenced non-existent rust:1.81 image tag - ❌ sqlx tried to connect to DB at build time - ❌ Separate test + build jobs - ❌ CI only tested mem-ingest (missed mem-cli errors) **Now**: ✅ Dockerfile fixed ✅ CI tests ALL packages ❌ **NEW ISSUE**: mem-cli fails to compile (29 errors) ## What Was Fixed ### 1. ✅ Dockerfile: rust:1-bookworm + SQLX_OFFLINE **File**: Dockerfile - FROM rust:1-bookworm (stable) - ENV SQLX_OFFLINE=true (use offline cache) - RUN cargo build --release -p mem-cli ### 2. ✅ .sqlx/ Query Cache (Checked In) **Files**: .sqlx/*.json (5 compiled queries) - Enables offline sqlx builds - Prevents DB connection at build time ### 3. ✅ Borrow Checker Fixes: versioning.rs **File**: crates/mem-store/src/versioning.rs - 36 lines refactored - No overlapping borrows - 0 borrow checker errors ✓ ### 4. ✅ Unified CI Workflow (IMPROVED) **File**: .gitea/workflows/build.yaml - Latest commit (08b2c44) - ✅ Build all packages: `cargo build --all` - ✅ Test all packages: `cargo test --all --lib` - ✅ Clippy linting (catches compile-time errors) - ✅ Docker build/push only on push/dispatch (not PR) ## ❌ Compilation Errors (MUST FIX) Running `cargo test --all --lib` reveals 29 errors in mem-cli: ### Group 1: Missing sqlx cache (2 errors) ``` error: set `DATABASE_URL` or run `cargo sqlx prepare` → crates/mem-cli/src/handlers/rebuild_handler.rs:196 (SELECT id FROM memory_entity) → crates/mem-cli/src/handlers/rebuild_handler.rs:208 (SELECT id FROM memory_edge) ``` **Fix**: Run against live DB to generate cache ```bash DATABASE_URL=postgresql://... cargo sqlx prepare -p mem-cli ``` ### Group 2: Missing imports/modules (11 errors) ``` error[E0432]: unresolved import `crate::auth` → versioning_handler.rs, ranking_handler.rs, rebuild_handler.rs error[E0432]: unresolved import `mem_store::db_repo` → ingest_with_persistence.rs error[E0432]: unresolved import `crate::agent::DefaultAgent` → agent_handler.rs error[E0432]: unresolved import `crate::answer_validator` → query_router.rs ``` **Fix**: Add missing modules to lib.rs exports ### Group 3: Missing dependencies (2 errors) ``` error[E0433]: cannot find `futures_util` → visualize_sse.rs (StreamExt) error[E0433]: cannot find `async_stream` → visualize_sse.rs (async_stream::stream!) error[E0433]: cannot find `rand` → agent/webhook_handler.rs ``` **Fix**: Add to Cargo.toml ```toml futures-util = "0.3" async-stream = "0.3" rand = "0.8" ``` ### Group 4: Missing types (7 errors) ``` error[E0425]: cannot find type `AppState` → unified_synthesis.rs, agent_handler.rs (5 occurrences) error[E0425]: cannot find function `unauthorized` → unified_synthesis.rs, agent_handler.rs (response_builder::unauthorized) error[E0106]: missing lifetime specifier → community_metrics.rs:208 (fn with &[CommunityMetrics]) ``` **Fix**: - Define AppState in main.rs or lib.rs - Add unauthorized() to response_builder module - Add lifetime to community_metrics function signature ### Group 5: Missing handler registrations (3 errors) ``` error[E0425]: cannot find `visualize_handler` → http_server.rs:413 error[E0425]: cannot find `visualize_stream_handler` → http_server.rs:414 error[E0425]: cannot find `compact_handler` → http_server.rs:415 ``` **Fix**: Import handlers in http_server.rs ```rust use crate::handlers::{visualize_handler, visualize_stream_handler, compact_handler}; ``` ## Test Results **✅ mem-ingest**: 81/81 tests passing ``` test result: ok. 81 passed; 0 failed ``` **❌ mem-cli**: 29 compilation errors (blocking) **❌ mem-store**: Blocked by mem-cli errors **❌ mem-core**: Not yet tested (likely blocked) ## What to Do ### Option A: Merge as-is (NOT RECOMMENDED) - Dockerfile is correct ✓ - CI workflow is good ✓ - But CI will **FAIL** when running on main (mem-cli won't compile) ### Option B: Fix errors before merge (RECOMMENDED) 1. **Generate missing sqlx cache**: ```bash export DATABASE_URL=postgresql://... cargo sqlx prepare -p mem-cli git add .sqlx/ git commit -m "chore: update sqlx cache for rebuild_handler queries" ``` 2. **Add missing modules to lib.rs**: - mem-store: export db_repo - mem-cli: export auth, answer_validator, agent::DefaultAgent 3. **Add missing dependencies**: - futures-util, async-stream, rand in Cargo.toml 4. **Fix type definitions**: - Define AppState in main.rs - Add unauthorized() to response_builder - Fix lifetime in community_metrics 5. **Register handlers**: - Import handlers in http_server.rs - Wire routes in main() 6. **Verify compilation**: ```bash cargo test --all --lib cargo build --all ``` ## Files to Check - ❌ crates/mem-cli/src/lib.rs (export missing modules) - ❌ crates/mem-cli/src/main.rs (define AppState, register handlers) - ❌ crates/mem-cli/src/response_builder.rs (add unauthorized()) - ❌ crates/mem-cli/src/query/community_metrics.rs (fix lifetime) - ❌ crates/mem-cli/Cargo.toml (add futures-util, async-stream, rand) - ❌ crates/mem-cli/src/handlers/rebuild_handler.rs (needs sqlx cache) - ✅ Dockerfile (correct) - ✅ .gitea/workflows/build.yaml (correct) - ✅ crates/mem-store/src/versioning.rs (correct) ## Recommendation **DO NOT MERGE** until all 29 errors are fixed. The Dockerfile changes are good, but CI will fail on the build stage because mem-cli won't compile.

rock force-pushed fix/dockerfile from 61d5e354cb to ee7fbbc460 2026-09-07 20:40:59 +00:00 Compare

rock force-pushed fix/dockerfile from ee7fbbc460 to d8f1f471e8 2026-09-07 20:41:47 +00:00 Compare

rock force-pushed fix/dockerfile from d8f1f471e8 to ac798f352f 2026-09-07 20:54:19 +00:00 Compare

rock force-pushed fix/dockerfile from ac798f352f to 5ee5dfe122 2026-09-07 21:18:24 +00:00 Compare

rock added 1 commit 2026-09-07 23:43:31 +00:00

fix: sqlx offline cache + borrow fix + Dockerfile + unified CI ... f2975b82c2

- Add .sqlx/ query cache (generated from live DB)
- SQLX_OFFLINE=true in Dockerfile (no DB at build time)
- Fix borrow checker errors in versioning.rs (ref from)
- rust:1.81 → rust:1-bookworm
- cargo build --release -p mem-cli
- Single CI job, DOCKER_HOST, build+push on all events

rock force-pushed fix/dockerfile from 5ee5dfe122 to f2975b82c2 2026-09-07 23:43:31 +00:00 Compare

rock added 1 commit 2026-09-08 00:00:38 +00:00

ci: comprehensive build + test + push workflow for all packages ... 08b2c4470c

## Problems fixed:
- Workflow only tested mem-ingest, missing mem-cli + mem-llm + mem-store errors
- No early error detection (build step missing)
- No linting/code quality checks
- Docker operations ran on all events (should be push/dispatch only)

## Changes:
- ✅ Build all packages (cargo build --all)
- ✅ Test all packages (cargo test --all --lib)
- ✅ Clippy linting (catches E0106, E0425, E0432, E0433 at compile time)
- ✅ Docker build/push only on main/dispatch (not on PRs)
- ✅ Full output (150 lines) for debugging
- ✅ Conditional gates for push-only operations

rock added 1 commit 2026-09-08 00:15:35 +00:00

fix: resolve 29 mem-cli compilation errors ... ce6ddc2b3d

- Add missing dependencies: futures-util, async-stream, rand
- Create auth/mod.rs to export AuthProvider, AuthError, Claims
- Add unauthorized() to response_builder for 401 responses
- Fix lifetime specifier in community_metrics::rank_by_metric()
- Create DefaultAgent type alias in agent module
- Export AppState and AuthMode from http_server
- Fix answer_validator import path (crate::query::answer_validator)
- Replace sqlx::query! macros with runtime queries in rebuild_handler
- Add mem-store db_repo to exports (temporarily disabled due to schema mismatches)
- Import visualize_handler, visualize_stream_handler, compact_handler in http_server
- Define LlmCaller trait locally in compaction.rs

Test Status:
- ✅ mem-ingest: 81/81 tests passing
- ⏳ mem-cli: compilation in progress (reduced from 29 errors)

rock added 1 commit 2026-09-08 00:54:42 +00:00

fix: resolve all 75 mem-cli compilation errors across 25 files ... cc4ba87e2d

- embed_text -> embed_one + Vector to Vec<f32> conversion (semantic.rs, unified_query.rs)
- DefaultAgent: remove shadowing type alias, re-export concrete struct
- Position: add Default derive for unwrap_or_default()
- streaming_body -> streaming + yield Result<Bytes> for SSE
- borrow-after-move: compute len before move in 6 places
- add missing imports: sqlx::Row, chrono::Timelike, std::pin::Pin
- add missing derives: Serialize on CompactionStats, FacetFilters
- extract_token: extract Authorization header from HttpRequest first
- AuthError variants: match actual enum (TokenExpired, not ExpiredToken)
- validate_bearer_token -> extract_bearer_token (sync check)
- check_limit -> check with correct args
- link_entities -> link_mentions (async, correct signature)
- InferenceEngine::new + infer_facts: match actual 2-arg/3-arg API
- RoutedResult: add missing confidence_score + is_valid fields
- client_sdk: fix ownership (remove borrow, save status before .text())
- index_chunk -> index_document (match OpenSearchClient API)
- recursive async dfs_paths: Box::pin for infinite future size
- log -> tracing crate in authentik_service_account
- CI: add SQLX_OFFLINE=true env var for offline builds

rock merged commit d8c3b06cb0 into main 2026-09-08 01:11:17 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

memory-observability

Observability implementation tasks

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

poimen rock (Rock)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: riotpiao-poimen/poimen-memory#26