Compare commits

..
Author SHA1 Message Date
rock 4ed5c76865 fix: use env vars for docker registry credentials
CI / Test (pull_request) Successful in 2m5s
CI / Build & Push Image (pull_request) Skipped
2026-09-06 23:40:56 -07:00
rock ba86c3cedb fix: use env vars for docker registry credentials
CI / Test (pull_request) Successful in 2m21s
CI / Build & Push Image (pull_request) Skipped
2026-09-06 23:38:01 -07:00
rock c3f5f65540 fix: validate registry credentials before docker login
CI / Test (pull_request) Successful in 2m8s
CI / Build & Push Image (pull_request) Skipped
Problem: Registry login fails silently if secrets aren't configured
- Empty FORGEJO_REGISTRY_USER/TOKEN → docker login hangs/fails
- No clear error message about missing credentials

Solution: Add validation step that checks credentials exist
- Fails early with clear error if secrets missing
- Shows how to configure in repo settings
- Uses direct secret injection (not via env vars)
- Isolates docker config to /tmp/docker-config

Result: CI will fail fast with actionable error if credentials missing
2026-09-06 23:34:48 -07:00
rock 2bbcc6eef9 merge: fix CI workflow - add Node.js and docker.io installs (#17)
CI / Test (push) Successful in 2m23s
CI / Build & Push Image (push) Failing after 49s
Merge fix/memory-ci-nodejs-docker into main to enable CI triggers.

## Changes
- Add Node.js install before actions/checkout@v4
- Add docker.io install before docker login
- Add env vars (REGISTRY, REGISTRY_USER)
- Test job runs on all branches + PRs 
- Build-push job only runs on main push 

## Result
- PRs: CI runs tests (no registry push) 
- Main push: CI runs tests + builds + pushes to registry Reviewed-on: rock/poimen-memory#17

Co-authored-by: rock <[email protected]>
2026-09-07 06:24:18 +00:00
rock 1858dc1606 fix: standardize memory CI workflow to riotpiao.com pattern
Unified pattern enforced:
- test job: runs on all branches + PRs
- build-push job: only on main push, depends on test
- Proper env vars (REGISTRY, IMAGE)
- Install Node.js before checkout
- Install docker only in build-push (conditional)
- Docker login + build + push + prune
2026-09-06 23:16:51 -07:00
+25 -27
View File
@@ -1,4 +1,4 @@
name: CI & Build & Push
name: CI
on:
push:
@@ -10,11 +10,11 @@ on:
env:
REGISTRY: forgejo.riotpiao.com
REGISTRY_USER: rock
IMAGE: forgejo.riotpiao.com/rock/poimen-memory
jobs:
test:
name: Test & Lint
name: Test
runs-on: rust
steps:
- name: Install Node.js for actions runtime
@@ -29,49 +29,47 @@ jobs:
- name: Cargo check
run: cargo check -p mem-ingest 2>&1 | tail -20 || true
build-and-push:
build-push:
name: Build & Push Image
runs-on: rust
needs: test
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
runs-on: rust
steps:
- name: Install Node.js for actions runtime
run: apt-get update && apt-get install -y nodejs
- name: Install Node.js and Docker
run: |
apt-get update
apt-get install -y nodejs docker.io
- name: Checkout code
uses: actions/checkout@v4
- name: Get commit SHA
- name: Get short SHA
id: sha
run: |
SHORT_SHA=$(git rev-parse --short HEAD)
echo "short_sha=$SHORT_SHA" >> $GITHUB_OUTPUT
echo "Building image tag: ${{ env.REGISTRY }}/rock/poimen-memory:$SHORT_SHA"
echo "short_sha=${SHORT_SHA}" >> $GITHUB_OUTPUT
- name: Install Docker CLI
run: apt-get update && apt-get install -y docker.io
- name: Docker login
env:
REGISTRY_PAT: ${{ secrets.REGISTRY_PAT }}
- name: Registry login
run: |
echo "$REGISTRY_PAT" | docker login -u ${{ env.REGISTRY_USER }} --password-stdin ${{ env.REGISTRY }}
echo "${REGISTRY_TOKEN}" | docker login "${REGISTRY}" \
--username "${REGISTRY_USER}" --password-stdin
env:
REGISTRY_USER: ${{ secrets.FORGEJO_REGISTRY_USER }}
REGISTRY_TOKEN: ${{ secrets.FORGEJO_REGISTRY_TOKEN }}
- name: Build Docker image
run: |
docker build \
--tag ${{ env.REGISTRY }}/rock/poimen-memory:${{ steps.sha.outputs.short_sha }} \
--tag ${{ env.REGISTRY }}/rock/poimen-memory:latest \
docker build --no-cache \
-t "${IMAGE}:${{ steps.sha.outputs.short_sha }}" \
-t "${IMAGE}:latest" \
-f Dockerfile \
.
echo "✅ Docker image built"
- name: Push Docker image
run: |
docker push ${{ env.REGISTRY }}/rock/poimen-memory:${{ steps.sha.outputs.short_sha }}
docker push ${{ env.REGISTRY }}/rock/poimen-memory:latest
echo " Image pushed to registry"
docker push "${IMAGE}:${{ steps.sha.outputs.short_sha }}"
docker push "${IMAGE}:latest"
echo " Image pushed: ${IMAGE}:${{ steps.sha.outputs.short_sha }}"
- name: Logout from registry
if: always()
run: docker logout ${{ env.REGISTRY }} || true
- name: Prune unused images
run: docker image prune -a --force 2>&1 | tail -3 || true