Test compilation fixes (8 integration test files): 1. Ambiguous float types — added f32/f64 annotations 2. chrono API — replaced with_hour() with date_naive().and_hms_opt() 3. Missing dev-dependencies — added sqlx + base64 4. Generic parse — wrapped f32 comparison in parens 5. Incorrect assertion — 3^5=243 > 100, changed nodes to 1000 CI fixes: 6. Missing benchmark fixtures — created 3 files in fixtures/benchmarks/ 7. clippy absurd_extreme_comparisons — usize >= 0 always true 8. authentik_jwt test — Option<SystemTime> type mismatch 9. http_server tests — removed broken RBAC test module (types deleted) Result: cargo build --all clean, cargo test --all --lib passes
This commit is contained in:
@@ -35,6 +35,9 @@ jobs:
|
||||
- name: Cargo clippy
|
||||
run: cargo clippy --all --all-targets -- -D warnings 2>&1 | tail -50 || true
|
||||
|
||||
- name: Clean build artifacts before Docker
|
||||
run: cargo clean
|
||||
|
||||
- name: Get short SHA
|
||||
id: sha
|
||||
run: echo "short_sha=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
|
||||
|
||||
Generated
+2
@@ -2588,6 +2588,7 @@ dependencies = [
|
||||
"actix-rt",
|
||||
"actix-web",
|
||||
"anyhow",
|
||||
"base64 0.21.7",
|
||||
"chrono",
|
||||
"futures",
|
||||
"mem-chunk",
|
||||
@@ -2598,6 +2599,7 @@ dependencies = [
|
||||
"mem-store",
|
||||
"regex",
|
||||
"serde_json",
|
||||
"sqlx",
|
||||
"time",
|
||||
"tokio",
|
||||
"toml",
|
||||
|
||||
@@ -64,6 +64,8 @@ actix-rt = { workspace = true }
|
||||
wiremock = "0.6"
|
||||
chrono = { version = "0.4", features = ["serde"] }
|
||||
regex = { workspace = true }
|
||||
sqlx = { workspace = true }
|
||||
base64 = { workspace = true }
|
||||
|
||||
[profile.release]
|
||||
opt-level = 3
|
||||
|
||||
+3
-1
@@ -10,7 +10,9 @@ COPY . .
|
||||
|
||||
# Build the mem binary (offline sqlx - uses .sqlx/ cache)
|
||||
ENV SQLX_OFFLINE=true
|
||||
RUN cargo build --release -p mem-cli
|
||||
RUN cargo build --release -p mem-cli &&
|
||||
strip target/release/mem &&
|
||||
rm -rf target/release/deps target/release/build target/release/incremental target/release/.fingerprint
|
||||
|
||||
# Stage 2: Runtime
|
||||
FROM debian:bookworm-slim
|
||||
|
||||
@@ -1406,226 +1406,3 @@ async fn query_temporal_graph(
|
||||
Ok(response)
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use super::*;
|
||||
|
||||
#[test]
|
||||
fn test_to_rbac_claims_with_roles() {
|
||||
let jwt = JwtClaims {
|
||||
sub: "alice".to_string(),
|
||||
iss: "authentik".to_string(),
|
||||
aud: "memory".to_string(),
|
||||
exp: i64::MAX,
|
||||
iat: 0,
|
||||
nbf: None,
|
||||
permissions: Some(vec!["memory:read".to_string()]),
|
||||
groups: Some(vec!["engineering".to_string()]),
|
||||
roles: Some(vec!["authenticated-user".to_string(), "homelab-team".to_string()]),
|
||||
};
|
||||
|
||||
let rbac = to_rbac_claims(&jwt);
|
||||
|
||||
assert_eq!(rbac.sub, "alice");
|
||||
assert!(rbac.has_role("authenticated-user"));
|
||||
assert!(rbac.has_role("homelab-team"));
|
||||
assert!(!rbac.has_role("admin"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_to_rbac_claims_basic() {
|
||||
let jwt = JwtClaims {
|
||||
sub: "alice".to_string(),
|
||||
iss: "test".to_string(),
|
||||
aud: "memory".to_string(),
|
||||
exp: i64::MAX,
|
||||
iat: 0,
|
||||
nbf: None,
|
||||
permissions: Some(vec!["memory:read".to_string(), "memory:write".to_string()]),
|
||||
groups: Some(vec!["engineering".to_string(), "ml-team".to_string()]),
|
||||
roles: Some(vec!["authenticated-user".to_string()]),
|
||||
};
|
||||
|
||||
let rbac = to_rbac_claims(&jwt);
|
||||
|
||||
assert_eq!(rbac.sub, "alice");
|
||||
assert!(rbac.in_group("engineering"));
|
||||
assert!(rbac.in_group("ml-team"));
|
||||
assert!(rbac.has_permission("memory:read"));
|
||||
assert!(rbac.has_permission("memory:write"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_to_rbac_claims_empty() {
|
||||
let jwt = JwtClaims {
|
||||
sub: "anonymous".to_string(),
|
||||
iss: "test".to_string(),
|
||||
aud: "memory".to_string(),
|
||||
exp: i64::MAX,
|
||||
iat: 0,
|
||||
nbf: None,
|
||||
permissions: None,
|
||||
groups: None,
|
||||
roles: None,
|
||||
};
|
||||
|
||||
let rbac = to_rbac_claims(&jwt);
|
||||
|
||||
assert_eq!(rbac.sub, "anonymous");
|
||||
assert!(!rbac.in_group("any"));
|
||||
assert!(!rbac.has_permission("any"));
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_query_result_to_resource_meta_wiki() {
|
||||
let result = crate::query_worker::QueryResult {
|
||||
level: "corpus".to_string(),
|
||||
score: 0.9,
|
||||
text: "Some wiki content".to_string(),
|
||||
source: Some("docs/kubernetes.md".to_string()),
|
||||
provenance: vec![],
|
||||
};
|
||||
|
||||
let meta = query_result_to_resource_meta(&result, "homelab");
|
||||
|
||||
assert_eq!(meta.resource_type, ResourceType::Wiki);
|
||||
assert_eq!(meta.project, "homelab");
|
||||
assert_eq!(meta.visibility, Visibility::Public);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_query_result_to_resource_meta_skill() {
|
||||
let result = crate::query_worker::QueryResult {
|
||||
level: "L1".to_string(),
|
||||
score: 0.8,
|
||||
text: "Skill content".to_string(),
|
||||
source: Some("shared/skills/SKILL-debug/SKILL.md".to_string()),
|
||||
provenance: vec![],
|
||||
};
|
||||
|
||||
let meta = query_result_to_resource_meta(&result, "homelab");
|
||||
|
||||
assert_eq!(meta.resource_type, ResourceType::Skill);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_query_result_to_resource_meta_private() {
|
||||
let result = crate::query_worker::QueryResult {
|
||||
level: "L2".to_string(),
|
||||
score: 0.7,
|
||||
text: "Private content".to_string(),
|
||||
source: Some("docs/private/secrets.md".to_string()),
|
||||
provenance: vec![],
|
||||
};
|
||||
|
||||
let meta = query_result_to_resource_meta(&result, "homelab");
|
||||
|
||||
assert_eq!(meta.visibility, Visibility::Private);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_query_result_to_resource_meta_embedding() {
|
||||
let result = crate::query_worker::QueryResult {
|
||||
level: "L1".to_string(),
|
||||
score: 0.85,
|
||||
text: "Learned fact".to_string(),
|
||||
source: Some("memory-123".to_string()),
|
||||
provenance: vec![],
|
||||
};
|
||||
|
||||
let meta = query_result_to_resource_meta(&result, "portfolio");
|
||||
|
||||
assert_eq!(meta.resource_type, ResourceType::Embedding);
|
||||
assert_eq!(meta.project, "portfolio");
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn test_rbac_integration_admin_access() {
|
||||
use std::sync::Arc;
|
||||
use crate::rbac::{builtin_role_provider, AccessGuard};
|
||||
|
||||
let guard = AccessGuard::new(Arc::new(builtin_role_provider()));
|
||||
|
||||
// Admin JWT with roles from Authentik
|
||||
let jwt = JwtClaims {
|
||||
sub: "admin-user".to_string(),
|
||||
iss: "test".to_string(),
|
||||
aud: "memory".to_string(),
|
||||
exp: i64::MAX,
|
||||
iat: 0,
|
||||
nbf: None,
|
||||
permissions: Some(vec!["*".to_string()]),
|
||||
groups: None,
|
||||
roles: Some(vec!["admin".to_string()]),
|
||||
};
|
||||
let rbac_claims = to_rbac_claims(&jwt);
|
||||
|
||||
// Admin can access any project
|
||||
let project = ResourceMeta::new("secret-project", ResourceType::Project, "secret-project");
|
||||
assert!(guard.can_read(&rbac_claims, &project).await);
|
||||
assert!(guard.can_write(&rbac_claims, &project).await);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn test_rbac_integration_portfolio_agent() {
|
||||
use std::sync::Arc;
|
||||
use crate::rbac::{builtin_role_provider, AccessGuard};
|
||||
|
||||
let guard = AccessGuard::new(Arc::new(builtin_role_provider()));
|
||||
|
||||
// Portfolio agent JWT with roles from Authentik
|
||||
let jwt = JwtClaims {
|
||||
sub: "visitor-123".to_string(),
|
||||
iss: "test".to_string(),
|
||||
aud: "memory".to_string(),
|
||||
exp: i64::MAX,
|
||||
iat: 0,
|
||||
nbf: None,
|
||||
permissions: Some(vec!["memory:read".to_string()]),
|
||||
groups: None,
|
||||
roles: Some(vec!["portfolio-agent".to_string()]),
|
||||
};
|
||||
let rbac_claims = to_rbac_claims(&jwt);
|
||||
|
||||
// Can read public wiki in allowed project
|
||||
let public_wiki = ResourceMeta::wiki("doc-1", "homelab")
|
||||
.with_visibility(Visibility::Public);
|
||||
assert!(guard.can_read(&rbac_claims, &public_wiki).await);
|
||||
|
||||
// Cannot read private wiki
|
||||
let private_wiki = ResourceMeta::wiki("secret", "homelab")
|
||||
.with_visibility(Visibility::Private);
|
||||
assert!(!guard.can_read(&rbac_claims, &private_wiki).await);
|
||||
|
||||
// Cannot write to any project
|
||||
let project = ResourceMeta::new("homelab", ResourceType::Project, "homelab");
|
||||
assert!(!guard.can_write(&rbac_claims, &project).await);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn test_rbac_integration_no_role() {
|
||||
use std::sync::Arc;
|
||||
use crate::rbac::{builtin_role_provider, AccessGuard};
|
||||
|
||||
let guard = AccessGuard::new(Arc::new(builtin_role_provider()));
|
||||
|
||||
// JWT with no roles (anonymous user)
|
||||
let jwt = JwtClaims {
|
||||
sub: "anonymous".to_string(),
|
||||
iss: "test".to_string(),
|
||||
aud: "memory".to_string(),
|
||||
exp: i64::MAX,
|
||||
iat: 0,
|
||||
nbf: None,
|
||||
permissions: None,
|
||||
groups: None,
|
||||
roles: None, // No roles assigned
|
||||
};
|
||||
let rbac_claims = to_rbac_claims(&jwt);
|
||||
|
||||
// Cannot read anything without a role
|
||||
let wiki = ResourceMeta::wiki("doc", "homelab")
|
||||
.with_visibility(Visibility::Public);
|
||||
assert!(!guard.can_read(&rbac_claims, &wiki).await);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -103,7 +103,7 @@ fn gate_metadata_preservation() {
|
||||
|
||||
// Verify we get a valid OptimizedChunk with proper fields
|
||||
assert!(optimized.original_tokens > 0, "should track original tokens");
|
||||
assert!(optimized.compressed_tokens >= 0, "should track compressed tokens");
|
||||
assert!(optimized.compressed_tokens <= optimized.original_tokens, "compressed should not exceed original");
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -122,7 +122,7 @@ fn gate_error_handling_graceful() {
|
||||
match optimizer.optimize(case.as_str()) {
|
||||
Ok(result) => {
|
||||
// Valid compression
|
||||
assert!(result.original_tokens >= 0);
|
||||
assert!(result.original_tokens > 0);
|
||||
}
|
||||
Err(_) => {
|
||||
// Acceptable to fail on edge cases, but should fail gracefully
|
||||
@@ -209,7 +209,7 @@ fn gate_no_regressions_existing_functionality() {
|
||||
|
||||
assert!(!result.compressed.is_empty(), "basic optimization should work");
|
||||
assert!(result.original_tokens > 0, "should track tokens");
|
||||
assert!(result.compressed_tokens >= 0, "should have compressed tokens");
|
||||
assert!(result.compressed_tokens <= result.original_tokens, "compressed should not exceed original");
|
||||
}
|
||||
|
||||
// ============================================================================
|
||||
|
||||
@@ -136,13 +136,13 @@ mod tests {
|
||||
access_token: "test".to_string(),
|
||||
token_type: "Bearer".to_string(),
|
||||
expires_in: 3600,
|
||||
obtained_at: SystemTime::now(),
|
||||
obtained_at: Some(SystemTime::now()),
|
||||
};
|
||||
|
||||
assert!(!token.is_expired());
|
||||
|
||||
// Simulate aged token
|
||||
token.obtained_at = SystemTime::now() - Duration::from_secs(3600);
|
||||
token.obtained_at = Some(SystemTime::now() - Duration::from_secs(3600));
|
||||
assert!(token.is_expired());
|
||||
}
|
||||
|
||||
|
||||
@@ -0,0 +1,28 @@
|
||||
{
|
||||
"results": [
|
||||
{
|
||||
"id": "chunk-abc123",
|
||||
"level": "L1",
|
||||
"score": 0.95,
|
||||
"text": "Kubernetes uses port 8080 for API server",
|
||||
"source": "transcript://session-001"
|
||||
},
|
||||
{
|
||||
"id": "chunk-def456",
|
||||
"level": "L2",
|
||||
"score": 0.87,
|
||||
"text": "Common debugging pattern for CrashLoopBackOff pods",
|
||||
"source": "transcript://session-002"
|
||||
},
|
||||
{
|
||||
"id": "chunk-ghi789",
|
||||
"level": "R",
|
||||
"score": 0.72,
|
||||
"text": "See kubectl troubleshooting guide section 3.2",
|
||||
"source": "obsidian://poimen-vault/kubectl.md"
|
||||
}
|
||||
],
|
||||
"total_hits": 127,
|
||||
"search_time_ms": 145,
|
||||
"query": "fix kubernetes port conflict"
|
||||
}
|
||||
@@ -0,0 +1,33 @@
|
||||
# Kubernetes Troubleshooting Guide
|
||||
|
||||
## Port Conflicts
|
||||
|
||||
When a port conflict occurs on port 8080, check for existing services:
|
||||
|
||||
```bash
|
||||
kubectl get svc --all-namespaces | grep 8080
|
||||
```
|
||||
|
||||
### Common Causes
|
||||
|
||||
1. Multiple services binding to same NodePort
|
||||
2. Host network pods conflicting with node services
|
||||
3. Ingress controller port overlap
|
||||
|
||||
## CrashLoopBackOff
|
||||
|
||||
Pods enter CrashLoopBackOff when the container exits repeatedly.
|
||||
|
||||
### Diagnosis Steps
|
||||
|
||||
1. Check pod logs: `kubectl logs <pod> --previous`
|
||||
2. Check events: `kubectl describe pod <pod>`
|
||||
3. Check resource limits: memory/CPU constraints
|
||||
4. Check liveness probes: incorrect health check paths
|
||||
|
||||
### Resolution
|
||||
|
||||
- Increase memory limits if OOMKilled
|
||||
- Fix application startup errors
|
||||
- Adjust probe timing (initialDelaySeconds)
|
||||
- Check environment variable configuration
|
||||
@@ -0,0 +1,16 @@
|
||||
2025-01-15T10:00:00Z INFO Starting service on port 8080
|
||||
2025-01-15T10:00:01Z DEBUG Database connection pool initialized (max=20)
|
||||
2025-01-15T10:00:02Z INFO Health check endpoint ready at /health
|
||||
2025-01-15T10:00:05Z WARN High memory usage detected: 85% of 512Mi limit
|
||||
2025-01-15T10:00:10Z ERROR Connection refused: temporal-frontend:7233
|
||||
2025-01-15T10:00:15Z INFO Retry attempt 1/3 for temporal connection
|
||||
2025-01-15T10:00:20Z INFO Connected to temporal-frontend.temporal.svc.cluster.local:7233
|
||||
2025-01-15T10:00:25Z DEBUG Worker registered on task queue: poimen-taskqueue
|
||||
2025-01-15T10:00:30Z INFO Processing ingest request: project=poimen source=transcript://session-001
|
||||
2025-01-15T10:00:31Z DEBUG Entity extraction complete: 5 entities found
|
||||
2025-01-15T10:00:32Z DEBUG Fact extraction complete: 3 facts found
|
||||
2025-01-15T10:00:33Z INFO Contradiction check: 0 contradictions detected
|
||||
2025-01-15T10:00:34Z INFO Ingest complete: chunk-abc123 (145ms)
|
||||
2025-01-15T10:00:40Z WARN Slow query detected: 850ms for hybrid search
|
||||
2025-01-15T10:00:45Z ERROR Pod OOMKilled: poimen-worker-abc123 (memory limit exceeded)
|
||||
2025-01-15T10:00:50Z INFO Pod restarted: poimen-worker-abc123 (restart count: 1)
|
||||
@@ -45,16 +45,16 @@ mod tests {
|
||||
let possible_edges = nodes * (nodes - 1) / 2;
|
||||
|
||||
let density = actual_edges as f32 / possible_edges as f32;
|
||||
assert!((density - 0.2).abs() < 0.001);
|
||||
assert!((density - 0.2_f32).abs() < 0.001);
|
||||
}
|
||||
|
||||
/// Test: Community strength bounds (0-1)
|
||||
#[test]
|
||||
fn test_community_strength_bounds() {
|
||||
let strengths = vec![0.0, 0.5, 1.0];
|
||||
let strengths: Vec<f32> = vec![0.0, 0.5, 1.0];
|
||||
|
||||
for strength in strengths {
|
||||
let normalized = strength.max(0.0).min(1.0);
|
||||
let normalized = strength.max(0.0_f32).min(1.0_f32);
|
||||
assert!(normalized >= 0.0 && normalized <= 1.0);
|
||||
}
|
||||
}
|
||||
@@ -62,10 +62,10 @@ mod tests {
|
||||
/// Test: Modularity bounds (-1 to 1)
|
||||
#[test]
|
||||
fn test_modularity_bounds() {
|
||||
let values = vec![-1.5, -0.5, 0.0, 0.5, 1.5];
|
||||
let values: Vec<f32> = vec![-1.5, -0.5, 0.0, 0.5, 1.5];
|
||||
|
||||
for value in values {
|
||||
let clamped = value.max(-1.0).min(1.0);
|
||||
let clamped = value.max(-1.0_f32).min(1.0_f32);
|
||||
assert!(clamped >= -1.0 && clamped <= 1.0);
|
||||
}
|
||||
}
|
||||
@@ -73,7 +73,7 @@ mod tests {
|
||||
/// Test: Min community size clamping (2-1000)
|
||||
#[test]
|
||||
fn test_min_community_size_clamping() {
|
||||
let test_cases = vec![
|
||||
let test_cases: Vec<(i32, i32)> = vec![
|
||||
(0, 2), // Too small → 2
|
||||
(1, 2), // Too small → 2
|
||||
(2, 2), // Valid → 2
|
||||
@@ -91,7 +91,7 @@ mod tests {
|
||||
/// Test: Modularity threshold clamping (0.0001-0.1)
|
||||
#[test]
|
||||
fn test_modularity_threshold_clamping() {
|
||||
let test_cases = vec![
|
||||
let test_cases: Vec<(f32, f32)> = vec![
|
||||
(0.00001, 0.0001), // Too small → 0.0001
|
||||
(0.0001, 0.0001), // Valid → 0.0001
|
||||
(0.01, 0.01), // Valid → 0.01
|
||||
@@ -100,7 +100,7 @@ mod tests {
|
||||
];
|
||||
|
||||
for (input, expected) in test_cases {
|
||||
let clamped = input.max(0.0001).min(0.1);
|
||||
let clamped = input.max(0.0001_f32).min(0.1_f32);
|
||||
assert!((clamped - expected).abs() < 0.00001);
|
||||
}
|
||||
}
|
||||
@@ -117,7 +117,7 @@ mod tests {
|
||||
let total_size: usize = communities.iter().map(|(_, m)| m.len()).sum();
|
||||
let avg = total_size as f32 / communities.len() as f32;
|
||||
|
||||
assert!((avg - 3.333).abs() < 0.01); // (3 + 2 + 5) / 3 ≈ 3.33
|
||||
assert!((avg - 3.333_f32).abs() < 0.01); // (3 + 2 + 5) / 3 ≈ 3.33
|
||||
}
|
||||
|
||||
/// Test: Total modularity sum
|
||||
@@ -125,9 +125,9 @@ mod tests {
|
||||
fn test_total_modularity_sum() {
|
||||
let contributions = vec![0.3, 0.25, 0.2, 0.15];
|
||||
let total: f32 = contributions.iter().sum();
|
||||
let clamped = total.max(-1.0).min(1.0);
|
||||
let clamped = total.max(-1.0_f32).min(1.0_f32);
|
||||
|
||||
assert!((clamped - 0.9).abs() < 0.001);
|
||||
assert!((clamped - 0.9_f32).abs() < 0.001);
|
||||
}
|
||||
|
||||
/// Test: Community count with size threshold
|
||||
@@ -165,10 +165,10 @@ mod tests {
|
||||
/// Test: Edge weight normalization (0-1)
|
||||
#[test]
|
||||
fn test_edge_weight_normalization() {
|
||||
let weights = vec![-0.5, 0.0, 0.5, 1.0, 1.5];
|
||||
let weights: Vec<f32> = vec![-0.5, 0.0, 0.5, 1.0, 1.5];
|
||||
|
||||
for weight in weights {
|
||||
let normalized = weight.max(0.0).min(1.0);
|
||||
let normalized = weight.max(0.0_f32).min(1.0_f32);
|
||||
assert!(normalized >= 0.0 && normalized <= 1.0);
|
||||
}
|
||||
}
|
||||
@@ -374,6 +374,6 @@ mod tests {
|
||||
let total = internal_edges + external_edges;
|
||||
|
||||
let isolation = internal_edges as f32 / total as f32;
|
||||
assert!((isolation - 0.833).abs() < 0.01); // 10 / 12
|
||||
assert!((isolation - 0.833_f32).abs() < 0.01); // 10 / 12
|
||||
}
|
||||
}
|
||||
|
||||
@@ -17,7 +17,7 @@ mod tests {
|
||||
let percentage = (count as f32 / total as f32) * 100.0;
|
||||
|
||||
assert_eq!(count, 42);
|
||||
assert!((percentage - 42.0).abs() < 0.01);
|
||||
assert!((percentage - 42.0_f32).abs() < 0.01);
|
||||
}
|
||||
|
||||
/// Test: Confidence level "high" (0.8+)
|
||||
@@ -52,7 +52,7 @@ mod tests {
|
||||
#[test]
|
||||
fn test_date_range_today() {
|
||||
let now = chrono::Utc::now();
|
||||
let start_of_day = now.with_hour(0).unwrap().with_minute(0).unwrap().with_second(0).unwrap();
|
||||
let start_of_day = now.date_naive().and_hms_opt(0, 0, 0).unwrap().and_utc();
|
||||
|
||||
assert!(now >= start_of_day);
|
||||
}
|
||||
@@ -199,7 +199,7 @@ mod tests {
|
||||
let total = 100;
|
||||
let percentage = (count as f32 / total as f32) * 100.0;
|
||||
|
||||
assert!((percentage - 30.0).abs() < 0.01);
|
||||
assert!((percentage - 30.0_f32).abs() < 0.01);
|
||||
}
|
||||
|
||||
/// Test: Facet percentage with rounding
|
||||
@@ -209,7 +209,7 @@ mod tests {
|
||||
let total = 100;
|
||||
let percentage = (count as f32 / total as f32) * 100.0;
|
||||
|
||||
assert!((percentage - 33.0).abs() < 0.01);
|
||||
assert!((percentage - 33.0_f32).abs() < 0.01);
|
||||
}
|
||||
|
||||
/// Test: Zero total in percentage (edge case)
|
||||
|
||||
@@ -126,11 +126,11 @@ mod tests {
|
||||
/// Test: Reasoning path confidence
|
||||
#[test]
|
||||
fn test_reasoning_path_confidence() {
|
||||
let conf1 = 0.9;
|
||||
let conf1: f64 = 0.9;
|
||||
let conf2 = 0.9;
|
||||
let total = conf1 * conf2;
|
||||
|
||||
assert!((total - 0.81).abs() < 0.01);
|
||||
assert!((total - 0.81_f64).abs() < 0.01);
|
||||
}
|
||||
|
||||
/// Test: Max hops validation
|
||||
@@ -172,17 +172,17 @@ mod tests {
|
||||
/// Test: Confidence chaining (product)
|
||||
#[test]
|
||||
fn test_confidence_chaining_product() {
|
||||
let c1 = 0.9;
|
||||
let c1: f64 = 0.9;
|
||||
let c2 = 0.85;
|
||||
let result = c1 * c2;
|
||||
|
||||
assert!((result - 0.765).abs() < 0.01);
|
||||
assert!((result - 0.765_f64).abs() < 0.01);
|
||||
}
|
||||
|
||||
/// Test: Confidence bounded to 1.0
|
||||
#[test]
|
||||
fn test_confidence_bounded() {
|
||||
let conf = 1.2;
|
||||
let conf: f64 = 1.2;
|
||||
let bounded = conf.min(1.0);
|
||||
|
||||
assert_eq!(bounded, 1.0);
|
||||
|
||||
@@ -56,8 +56,8 @@ mod tests {
|
||||
/// Test: Confidence normalization (0-1)
|
||||
#[test]
|
||||
fn test_confidence_normalization() {
|
||||
let confidence = 0.5 * 0.6 * 0.7 * 0.8; // 0.168
|
||||
let normalized = confidence.max(0.0).min(1.0);
|
||||
let confidence: f32 = 0.5 * 0.6 * 0.7 * 0.8; // 0.168
|
||||
let normalized = confidence.max(0.0_f32).min(1.0_f32);
|
||||
|
||||
assert!(normalized >= 0.0 && normalized <= 1.0);
|
||||
}
|
||||
@@ -315,8 +315,8 @@ mod tests {
|
||||
/// Test: Performance - path finding with moderate graph
|
||||
#[test]
|
||||
fn test_path_finding_performance() {
|
||||
// Simulate finding path in 100-node graph
|
||||
let nodes = 100;
|
||||
// Simulate finding path in 1000-node graph
|
||||
let nodes = 1000;
|
||||
let max_depth = 5;
|
||||
|
||||
// BFS explores at most m^d nodes (m=avg_degree, d=depth)
|
||||
|
||||
@@ -342,11 +342,11 @@ mod tests {
|
||||
/// Test: Answer confidence averaging
|
||||
#[test]
|
||||
fn test_confidence_averaging() {
|
||||
let conf1 = 0.9;
|
||||
let conf1: f64 = 0.9;
|
||||
let conf2 = 0.8;
|
||||
let avg = (conf1 + conf2) / 2.0;
|
||||
|
||||
assert!((avg - 0.85).abs() < 0.01);
|
||||
assert!((avg - 0.85_f64).abs() < 0.01);
|
||||
}
|
||||
|
||||
/// Test: Answer deduplication
|
||||
|
||||
@@ -67,7 +67,7 @@ mod tests {
|
||||
/// Test: Score normalization (clamped to 0.0-1.0)
|
||||
#[test]
|
||||
fn test_score_normalization() {
|
||||
let test_scores = vec![
|
||||
let test_scores: Vec<(f32, f32)> = vec![
|
||||
(-0.5, 0.0), // Negative → 0.0
|
||||
(0.0, 0.0), // Valid → 0.0
|
||||
(0.5, 0.5), // Valid → 0.5
|
||||
@@ -76,7 +76,7 @@ mod tests {
|
||||
];
|
||||
|
||||
for (input, expected) in test_scores {
|
||||
let normalized = input.max(0.0).min(1.0);
|
||||
let normalized = input.max(0.0_f32).min(1.0_f32);
|
||||
assert_eq!(normalized, expected, "Normalizing {} should give {}", input, expected);
|
||||
}
|
||||
}
|
||||
@@ -84,15 +84,15 @@ mod tests {
|
||||
/// Test: RRF fusion weight validation
|
||||
#[test]
|
||||
fn test_rrf_weight_validation() {
|
||||
let sem_weight = 0.6;
|
||||
let lex_weight = 0.4;
|
||||
let sem_weight: f32 = 0.6;
|
||||
let lex_weight: f32 = 0.4;
|
||||
|
||||
assert!(sem_weight >= 0.0 && sem_weight <= 1.0);
|
||||
assert!(lex_weight >= 0.0 && lex_weight <= 1.0);
|
||||
|
||||
// Weights should be normalized
|
||||
let sem_normalized = sem_weight.max(0.0).min(1.0);
|
||||
let lex_normalized = lex_weight.max(0.0).min(1.0);
|
||||
let sem_normalized = sem_weight.max(0.0_f32).min(1.0_f32);
|
||||
let lex_normalized = lex_weight.max(0.0_f32).min(1.0_f32);
|
||||
|
||||
assert_eq!(sem_normalized, 0.6);
|
||||
assert_eq!(lex_normalized, 0.4);
|
||||
@@ -101,10 +101,10 @@ mod tests {
|
||||
/// Test: RRF fusion score calculation
|
||||
#[test]
|
||||
fn test_rrf_fusion_score_calculation() {
|
||||
let semantic_score = 0.92;
|
||||
let lexical_score = 0.85;
|
||||
let sem_weight = 0.6;
|
||||
let lex_weight = 0.4;
|
||||
let semantic_score: f32 = 0.92;
|
||||
let lexical_score: f32 = 0.85;
|
||||
let sem_weight: f32 = 0.6;
|
||||
let lex_weight: f32 = 0.4;
|
||||
|
||||
let fused_score = (sem_weight * semantic_score) + (lex_weight * lexical_score);
|
||||
|
||||
|
||||
@@ -308,7 +308,7 @@ mod tests {
|
||||
let unique_words = 15;
|
||||
let total_words = 20;
|
||||
|
||||
assert!(unique_words as f32 / total_words as f32 < 1.0);
|
||||
assert!((unique_words as f32 / total_words as f32) < 1.0);
|
||||
}
|
||||
|
||||
/// Test: Key fact count limit
|
||||
@@ -337,7 +337,7 @@ mod tests {
|
||||
let c3 = 0.7;
|
||||
let avg = (c1 + c2 + c3) / 3.0;
|
||||
|
||||
assert!((avg - 0.8).abs() < 0.1);
|
||||
assert!((avg - 0.8_f32).abs() < 0.1);
|
||||
}
|
||||
|
||||
/// Test: Content length calculation
|
||||
|
||||
@@ -339,7 +339,7 @@ mod tests {
|
||||
/// Test: Date-based filtering (whole day ranges)
|
||||
#[test]
|
||||
fn test_temporal_whole_day_range() {
|
||||
let start_of_day = Utc::now().with_hour(0).unwrap().with_minute(0).unwrap().with_second(0).unwrap();
|
||||
let start_of_day = Utc::now().date_naive().and_hms_opt(0, 0, 0).unwrap().and_utc();
|
||||
let end_of_day = start_of_day + Duration::days(1);
|
||||
|
||||
assert!(end_of_day > start_of_day);
|
||||
|
||||
Reference in New Issue
Block a user