rock/poimen-workflows
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
83 Commits 15 Branches 0 Tags
ebf95506cd0cdd4418f2d0e02dfb83cecd3845d5
Commit Graph
9 Commits
Author SHA1 Message Date
Test ebf95506cd refactor: simplify auth - remove undefined TenantID concept 
- Remove TenantID field from LLMAuth (JWT claims handle tenant info)
- Remove Scopes field (not part of Poimen's design)
- Simplify to 3 core auth types: Bearer, API Key, Custom
- Update LLMRouterConfig to only include Auth field
- Simplify README examples to per-deployment pattern
- Focus on secure token management vs multi-tenant isolation
- Clarify token rotation pattern for long-running workflows
- Update security section with practical vault integration examples

TenantID was introduced without proper context. In Poimen:
- JWT token itself contains tenant/customer info in claims
- Each deployment gets its own LLM_AUTH_TOKEN from vault
- LLM API provider (riotpiao.com) validates token at their end
- No need for separate tenant header in Poimen layer

Simpler, clearer, more maintainable.
 2026-09-04 10:56:47 -07:00
Test 66c17e821f feat: add JWT/OAuth2 authentication & multi-tenant federation
ci / test (push) Failing after 1m49s
Details 
- Add LLMAuth struct with support for Bearer, API Key, and Custom auth types
- Implement applyAuth() to inject auth headers into LLM requests
- Add X-Tenant-ID header for multi-tenant isolation
- Add X-OAuth-Scopes header for OAuth2 scope enforcement
- Add UpdateAuth() for runtime token refresh (long-running workflows)
- Update LLMRouterConfig with Auth and TenantID fields
- Document 4 authentication patterns (Bearer, API Key, Custom, Router config)
- Add security best practices: token vault integration, tenant isolation, scopes
- Add audit headers for compliance & logging
- Create multi-tenant router factory pattern

Auth types supported:
- Bearer: JWT/OAuth2 tokens (most secure for federated access)
- API Key: Static keys (X-API-Key header)
- Custom: Any custom header-based scheme
- None: No authentication

Customers can now pass per-tenant JWT tokens with customized scopes
and isolated LLM API access per tenant/customer.
 2026-09-04 10:54:22 -07:00
Test 0d70da4f31 refactor: make routing system extensible with provider/builder interfaces
ci / test (push) Failing after 3m24s
Details 
BREAKING: LLMRouter now requires explicit LLMProvider

New Abstractions:
- LLMProvider interface: swap providers (OpenAI, Claude, local, etc)
- SpecBuilder interface: custom spec generation strategies
- ParameterBinder interface: flexible parameter resolution
- ActivityExecutor interface: pluggable activity execution
- WorkflowValidator interface: composable validation

Provider System:
- ProviderRegistry: manage multiple LLM providers
- RoutingProviderLLM: fallback across providers
- CachingLLMProvider: caching wrapper
- RetryingLLMProvider: retry wrapper

Spec Building:
- DefaultSpecBuilder: basic spec generation
- CronSpecBuilder: cron workflow specialization
- SpecBuilderFactory: builder selection
- CompositeSpecBuilder: multi-strategy fallback
- BuildMetadata: context for builders

Validators:
- StateGraphValidator: DAG structure
- ActivityAvailabilityValidator: activity existence
- TimeoutValidator: timeout format
- CompositeValidator: multiple validators
- TransitionValidator: state transitions

Refactored Components:
- LLMRouter: config-driven, provider-agnostic
- LLMClient: now implements LLMProvider
- llm_router.go: 97 fewer lines (delegated to builders)

Migration Path:
OLD: NewLLMRouter(kb)
NEW: NewLLMRouter(LLMRouterConfig{Provider: ..., KB: ...})
 2026-09-03 09:17:38 -07:00
Test 1c16869126 refactor: reduce CRAP scores in router/workflow/notification
ci / test (push) Successful in 3m42s
Details 
- llm_router.go: Extract getStringFromMap, firstNonEmpty, paramResolver
  - buildCronSpec: 12 → 4 complexity
  - buildParameters: 9 → 5 complexity

- routing_workflow.go: Extract stateMachine, stateResult types
  - RoutingWorkflow: 11 → 6 complexity
  - Separate executeTask/executePass/executeFail

- notification.go: Extract checker interface pattern
  - DeploymentPreCheckActivity: 10 → 5 complexity
  - goCheckers() returns language-specific checkers

- Added 7 new test cases for helper functions
- Coverage: internal/routing 63.6% → 66.0%
 2026-09-03 08:50:21 -07:00
Test a0e64224a7 feat: RoutingWorkflow + LLM Router + Memory Activity
ci / test (push) Successful in 2m12s
Details 
- Add RoutingWorkflow: generic state machine executor for WorkflowSpec
- Add LLM Router: natural language → WorkflowSpec generation
- Add RetrieveMemoryActivity: query poimen-memory for context
- Add activities: AnalyzeCode, SecurityScan, GenerateReport, Notify, etc.
- Add agent-prompts/router: LLM prompt documentation
- Extend starter with --route flag for routing workflows
- Remove orchestrator job (trigger via API/message instead)
- Clean up: move docs to Desktop, add .gitignore for *.md
 2026-09-02 19:21:53 -07:00
Test 5a465b145c feat(routing): implement JSONPath resolver 
Task 2.1 COMPLETE ✅

JSONPath expression resolution system for workflow parameter binding:

- jsonpath.go: Main resolver with methods:
  - NewJSONPathResolver(input, stepResults) - Create resolver
  - Resolve(expr) - Resolve single expression: ${input.repo}, ${Step.output.field}
  - ResolveString(str) - Resolve strings with multiple expressions
  - ResolvePaths(map) - Recursively resolve entire parameter maps
  - navigateObject(obj, parts) - Navigate through nested objects
  - resolveValue(value) - Resolve values recursively (strings, maps, slices)
  - ValidatePath(path) - Validate path syntax
  - GetAvailableSteps() - List available steps
  - GetInputFields() - List available input fields

- Supported expressions:
  - ${input.repo} - Access input parameters
  - ${Clone.output.path} - Access step results
  - ${Analyze.output.metrics.quality.score} - Deep nesting
  - String interpolation: "Path: ${Clone.output.path}"
  - Works with maps, slices, and nested structures

- jsonpath_test.go: 14 comprehensive tests
  - Single field resolution (input, steps)
  - Nested field access (deep nesting)
  - Non-template strings
  - Error handling (missing steps, missing fields)
  - String interpolation with multiple expressions
  - Map resolution (pure templates vs embedded expressions)
  - Nested maps and slices
  - String map support
  - Complex workflow scenarios
  - Empty input handling
  - All tests PASS ✅ (14/14 JSONPath tests)

Total tests now: 55/55 PASS ✅
- 8 type tests
- 14 knowledge base tests
- 30 validator tests
- 14 JSONPath tests

Acceptance criteria met:
✅ Resolves ${input.*} expressions
✅ Resolves ${Step.output.*} expressions
✅ Handles deep nesting
✅ String interpolation works
✅ Recursive resolution (maps, slices)
✅ Error handling for missing paths
✅ Pure template vs embedded expressions
✅ Ready for activity selection (Task 2.2)

Effort: 3 hours (estimated)
Files: jsonpath.go (209 lines)
       jsonpath_test.go (423 lines)

Phase 2 Progress: 1 of 5 tasks complete (20%)
 2026-08-31 19:46:10 -07:00
Test 687bdb21e0 feat(routing): implement WorkflowSpec validator 
Task 1.4 COMPLETE ✅

Comprehensive validation system for workflow specifications:

- validator.go: Main validator with methods:
  - NewValidator(kb) - Create validator with knowledge base
  - ValidateWorkflowSpec(spec) - Validate one-time workflows
  - ValidateCronWorkflowSpec(spec) - Validate scheduled workflows
  - validateState(state, path) - Validate individual states
  - validateDuration(dur) - Validate Go duration strings

- validator_cron.go: Cron expression validation:
  - validateCronExpression(expr) - 5-field cron validation
  - validateCronField(field, min, max, name) - Individual field validation
  - Supports: wildcards (*), ranges (0-59), steps (*/5), lists (0,15,30,45)

- validator_test.go: 30 comprehensive tests
  - Valid/invalid workflow specs
  - State name validation (duplicates, missing)
  - State transitions (Next field references)
  - Catch clause validation
  - Task state validation (activity exists in KB)
  - Pass/Fail state validation
  - Timeout format validation
  - Cron workflow validation
  - Timezone validation
  - Cron expression validation
  - All tests PASS ✅ (39/39 total in routing package)

Acceptance criteria met:
✅ Detects invalid workflow specs
✅ Validates state references and transitions
✅ Checks activities exist in knowledge base
✅ Validates timeout durations
✅ Validates cron expressions
✅ Validates timezones
✅ All validation tests pass
✅ Ready for Phase 2 (llm-router)

Effort: 3 hours (estimated)
Files: validator.go (281 lines)
       validator_cron.go (50 lines)
       validator_test.go (367 lines)

Phase 1 COMPLETE ✅
- Task 1.1: Types ✅
- Task 1.2: Knowledge Base ✅
- Task 1.3: KB Loader ✅
- Task 1.4: Validator ✅

Total Phase 1 Effort: 10 hours (on track with 8-10 estimate)
 2026-08-31 19:29:25 -07:00
Test ab79cf33bc feat(routing): implement ActivityKnowledgeBase with loader 
Task 1.2 & 1.3 COMPLETE ✅

Core knowledge base infrastructure:
- activity_knowledge_base.json: Catalog of 8 activities with metadata
  - CloneRepoActivity: Clone Git repo (stable, 1 retry)
  - AnalyzeCodeActivity: AST analysis (flaky, 3 retries)
  - SecurityScanActivity: SAST scanning (2 retries)
  - GenerateReportActivity: Report generation (1 retry)
  - DeploymentPreCheckActivity: Pre-deployment validation (flaky, 2 retries)
  - NotifyStatusActivity: Slack/email notifications (flaky, 3 retries)
  - ApproveWorkflowActivity: Human approval (120m timeout)
  - ArchiveResultsActivity: Cloud storage archival (flaky, 2 retries)

- knowledge_base.go: KnowledgeBase loader with methods:
  - LoadKnowledgeBase(path) - Load from JSON file
  - LoadKnowledgeBaseFromDefaultPath() - Auto-discover file
  - GetActivity(name) - Lookup single activity
  - GetActivityNames() - List all activity names
  - HasActivity(name) - Check existence
  - GetTimeoutForActivity(name) - Get timeout from KB
  - GetRetryPolicyForActivity(name) - Get retry config
  - IsFlaky(name) - Check if flaky
  - GetDependencies(name) - Get activity dependencies
  - ListActivitiesByCategory(category) - Filter by category
  - Validate() - Check for circular dependencies
  - PrintSummary() - Human-readable summary

- knowledge_base_test.go: 14 unit tests
  - Test loading, lookup, filtering, dependencies
  - Test timeout/retry extraction
  - Test validation logic
  - All tests PASS ✅ (22/22 total)

Acceptance criteria met:
✅ Knowledge base loads successfully
✅ All 8 activities properly defined
✅ Flaky/stable flags correctly set
✅ Dependencies validate with no cycles
✅ Timeout/retry extraction works
✅ Unit tests pass (14/14 KB tests)
✅ Ready for validator (Task 1.4)

Effort: 5 hours (estimated 3+2)
Files: activity_knowledge_base.json (10.3KB)
       knowledge_base.go (246 lines)
       knowledge_base_test.go (324 lines)
 2026-08-31 19:26:16 -07:00
Test 25a4787022 feat(routing): implement WorkflowSpec and CronWorkflowSpec types 
Task 1.1 COMPLETE ✅

Core type definitions for routing workflows:
- WorkflowSpec: One-time workflow specification
- CronWorkflowSpec: Scheduled workflow specification
- State: Individual step in workflow (Task/Pass/Fail)
- RetryPolicy: Retry configuration with backoff
- CatchClause: Error handling
- ExecutionContext: Tracks state during execution
- ActivityMetadata: Describes activity capabilities
- Supporting types: PollParams, Heartbeat, Result

All types support JSON marshaling/unmarshaling.
8 unit tests covering complex scenarios (9/9 PASS).

Acceptance criteria met:
✅ All types compile without errors
✅ JSON marshaling/unmarshaling works correctly
✅ Unit tests pass (complex workflow examples)
✅ Ready for next phase (Knowledge Base)

Effort: 2 hours
Files: internal/routing/types.go (159 lines)
       internal/routing/types_test.go (286 lines)
 2026-08-31 19:15:28 -07:00