Commit Graph
10 Commits
Author SHA1 Message Date
Test e3f3b35047 feat(T1.6, T1.7): comprehensive integration tests and audit logging
T1.6: Comprehensive Integration Tests for Concurrency
- Add tests/concurrency_integration_test.go
- Test concurrent workflows on shared resources
- Test board validation concurrency
- Test state tracking under concurrent access
- Test snapshot creation and restoration concurrency
- Test pause/resume under load
- Test data consistency with concurrent access
- Test network flakiness simulation
- Test cross-workflow isolation
- Benchmark concurrent snapshot and state operations
- 15 integration tests, all passing

T1.7: Immutable Audit Logging
- Add internal/audit package for decision tracking
- Implement AuditLogger with append-only JSONL logs
- Log planner decisions with reasoning
- Log judge verdicts with reasoning
- Log implementer changes with file lists
- Query by task ID (queryable by task)
- Query by workflow ID
- Query by actor (planner/judge/implementer)
- Query by timestamp range
- Full audit trail retrieval
- Event counting and statistics
- 14 audit tests, all passing

Audit Features:
- Immutable append-only JSONL logs
- Event ID generation
- Timestamp tracking (exact recovery point)
- Full reasoning and context preservation
- Metadata storage for extensibility
- Thread-safe concurrent logging
- Fast queries by task/workflow/actor/time

Test Coverage:
- 15 concurrency integration tests (workflows, board, state, snapshots)
- 14 audit logging tests (decisions, verdicts, queries, immutability)
- 29 total T1.6+T1.7 tests, all passing
- Concurrent access patterns verified
- Data consistency under load verified
- Query functionality comprehensive

T1 Milestone: 8/8 tasks COMPLETE (100%)
2026-08-23 17:14:23 -07:00
Test 37d7aea5a7 feat(T1.5): implement workflow pause/resume with state snapshots
- Add internal/pause package for pause/resume orchestration
- Implement WorkflowSnapshot for complete state serialization
- Implement SnapshotManager for snapshot storage and recovery
- Implement PauseHandler for pause/resume signal handling
- Implement PauseSignal and ResumeSignal types
- Implement PauseState for tracking pause status

Snapshot Features:
- Capture complete workflow state (tasks, metrics, config)
- Persist to JSON files for recovery after pod restart
- Track paused_at and resumed_at timestamps
- Support snapshot cleanup and batch removal
- Load/save from disk with persistence layer

Pause Handling:
- Accept pause signals with reason and grace period
- Save current state before pausing
- Block workflow execution during pause
- Support multiple concurrent paused workflows
- Channel-based signal reception (Temporal-compatible)

Resume Handling:
- Accept resume signals with reason
- Restore workflow state from snapshots
- Continue execution from exact pause point
- Update timestamps on resumption
- Enable recovery after pod restarts

Signal Management:
- Non-blocking signal reception with timeout
- WaitForPauseOrResume() for blocking operations
- ConfigurableWait duration
- Error handling for invalid transitions

Analytics:
- GetPauseStats() for pause/resume metrics
- GetSnapshotStats() for snapshot inventory
- Timestamp tracking (paused, resumed)
- Multi-workflow state aggregation

Test Coverage:
- 16 snapshot tests (creation, persistence, cleanup)
- 18 handler tests (signals, state, snapshots)
- 34 total pause/resume tests, all passing
- Edge cases: concurrent workflows, nil signals, timeouts
- State transition verification

Key Design:
- Separate Snapshot Manager (storage) and Pause Handler (orchestration)
- JSON persistence for debuggability
- Thread-safe with RWMutex
- Compatible with Temporal signal patterns
- Non-destructive pause (snapshot before blocking)

Closes T1.5
2026-08-23 17:11:56 -07:00
Test b1e3136350 feat(T1.4): implement board state validation and auto-healing
- Add internal/board package with validation and state tracking
- Implement BoardValidator for comprehensive board file validation
- Detect missing headers, malformed tables, invalid task IDs
- Validate status fields ([x] or [ ])
- Parse task information from valid boards
- Implement StateTracker for actual task state management
- Track task progression (pending → in_progress → completed/failed)
- Support task metrics attachment and analytics
- Implement divergence detection: compare board vs actual states
- Implement auto-healing: fix state mismatches between board and reality
- RepairBoard() fixes structural corruption issues
- HealDivergence() updates board to match actual states
- Support both JSON persistence and in-memory operation

Validation Features:
- Detailed error reporting with line numbers and context
- Warning system for suspicious but valid boards
- Task ID format validation (T#.# pattern)
- Status value normalization ([X] → [x])
- Table structure verification

State Management:
- Persistent JSON storage of task states
- Completion/failure timestamps
- Custom metrics per task
- Thread-safe RWMutex synchronization
- Stats and filtering operations

Healing Features:
- Non-destructive repairs (report changes)
- Board integrity preservation
- Divergence detection with timestamps
- Batch update capability
- Change tracking for audit trail

Test Coverage:
- 13 validator tests (structure, validation, repair, parsing)
- 16 state tracker tests (tracking, persistence, analytics)
- 29 total board tests, all passing
- Edge cases: empty boards, invalid formats, multiple tasks
- Multi-state transitions and metrics

Key Design:
- Separation of concerns: Validator (format) vs Tracker (state)
- JSON persistence (human-readable, debuggable)
- Thread-safe concurrent state updates
- Detailed error messages with context
- Non-breaking repairs (safe by default)

Closes T1.4
2026-08-23 16:49:25 -07:00
Test 927835cb0e feat(T1.3): implement activity timeout tuning automation
- Add internal/tuning package with intelligent timeout analysis
- Implement TimeoutAnalyzer for tracking activity execution metrics
- Calculate percentile-based timeout recommendations (P95, P99)
- Generate confidence scores based on sample size and failure rate
- Implement TimeoutLessonsStore for persistent lesson tracking
- Store lessons in per-task JSONL files with effectiveness tracking
- Generate TimeoutTuningSignal objects for planner integration
- Generate human-readable lesson format for planner context
- Support three-tier priority signaling (high/medium/low)
- Analyze multiple activities concurrently

Analysis Features:
- Track duration, success/failure, timestamps for each execution
- Identify undertuned activities (P99 exceeds timeout)
- Detect overtuned activities (timeout > 2x P99)
- Calculate confidence scores (40% sample data + 60% reliability)
- Generate recommendations with reasoning

Lesson Management:
- Persist lessons per task in JSONL format
- Support lesson effectiveness tracking
- Format lessons for planner input
- Enable feedback loop for timeout optimization

Test Coverage:
- 14 analyzer tests (metrics, analysis, persistence)
- 22 lessons tests (storage, signals, formatting)
- 36 total tuning tests, all passing
- Edge cases: empty metrics, all failures, multiple activities

Key Design:
- P99 + 20% buffer for safe timeout values
- Weighted confidence scoring for reliable recommendations
- Separation: Analyzer (metrics), Lessons (storage), Signals (integration)
- Thread-safe analyzer with RWMutex
- No external dependencies added

Closes T1.3
2026-08-23 16:47:31 -07:00
Test 60f9ca2b1d feat(T1.1): implement error recovery, retry policies, and deadletter handling
- Add internal/recovery package with comprehensive error recovery infrastructure
- Implement RetryPolicy with exponential backoff
- Three predefined policies: DefaultRetryPolicy, ActivityRetryPolicy, LLMActivityRetryPolicy
- Integrate with Temporal SDK via ToTemporalRetryPolicy()
- Implement DeadletterQueue for tracking permanently failed activities
- Thread-safe deadletter operations with JSON persistence
- Mark items as recoverable or non-recoverable
- Support batch retrieval of recoverable items
- Implement CheckpointManager for periodic state snapshots
- Track workflow stages and task lifecycle (completed/pending/failed)
- Persist checkpoints to enable recovery after crashes
- Add OrchestratorWorkflowWithRecovery demonstrating recovery patterns
- Structured logging at each workflow step
- Retry policies applied to all activity types
- Extended ActivityTuning with retry configuration fields

Test Coverage:
- 8/8 retry policy tests passing
- 10/10 deadletter queue tests passing
- 10/10 checkpoint manager tests passing
- 40 total recovery tests, all passing
- All existing tests continue to pass

Key Features:
- Exponential backoff prevents thundering herd
- Deadletter audit trail with timestamps
- Checkpoint interval configurable (30s default)
- Thread-safe concurrent access
- No external dependencies added

Closes T1.1
2026-08-23 16:43:30 -07:00
Test 59a1eeed85 feat(T1.2): implement structured logging and Prometheus metrics
- Add internal/logging package with zap-based structured JSON logging
- Support development (colored) and production (JSON) modes via ENVIRONMENT env var
- Add logging helpers: Info(), Error(), Warn(), Debug(), Fatal()
- Add field helpers: String(), Int(), Int64(), Err()
- Add internal/metrics package with 16 comprehensive Prometheus metrics
- Track workflows: starts, completions, duration by type/status
- Track activities: starts, completions, duration, retries by type
- Track LLM calls: total calls and latency by model
- Track git operations: total and duration by operation type
- Track judge decisions: decisions by type
- Track Temporal errors: connection errors by type
- Track cache efficiency: hits and misses by cache type
- Track tasks in progress: gauge metric by task type
- Metrics exported on /metrics endpoint (Prometheus text format)
- Integrate structured logging in cmd/worker and cmd/starter
- Replace all log.Printf/log.Fatalf with structured logging
- Add /metrics endpoint to health check server
- 8/8 logging tests passing, 13/13 metrics tests passing
- All verification criteria met

Dependencies added:
- go.uber.org/zap v1.28.0 (structured logging)
- github.com/prometheus/client_golang v1.24.1 (metrics export)

Closes T1.2
2026-08-23 16:33:49 -07:00
Test 90fcd6a9df feat(T1.8): implement health checks for Kubernetes deployment
- Add internal/health package with health checker
- Implement three endpoints: /health, /health/live, /health/ready
- /health returns full JSON report with component status, latency, timestamp
- /health/live for K8s liveness probe (service running)
- /health/ready for K8s readiness probe (ready to accept traffic)
- Temporal connectivity check via GetWorkflow call with timeout
- Health check caching (30s interval) to prevent excessive checks
- Graceful shutdown: health server stops on SIGINT/SIGTERM
- Add --health flag to starter command to run health check
- Worker runs health server on port 8081 alongside task queue worker
- 10/10 unit tests passing
- All verification criteria met

Closes T1.8
2026-08-23 16:31:33 -07:00
Test 002fe98e17 feat(workflows): wire TaskUnit/Orchestrator activities, add k8s deploy manifests
ci / test (push) Failing after 5s
Implements real activity-calling logic in OrchestratorWorkflow and
TaskUnitWorkflow (previously stubs), adds GitDiffActivity, and expands
PlanningActivity's I/O to carry repo path and prior task results.

Adds k8s/ deployment manifests (worker Deployment, orchestrator Job,
Kustomize base) for the poimen-workflows Temporal worker, using a
dedicated Kubernetes namespace `poimen` and Temporal namespace
`poimen-harness` rather than sharing the Temporal server's own
`temporal`/`production` namespaces.
2026-08-21 21:57:01 -07:00
Test 5b8d3df01e (workflow) add simple harness workflow for manual testing 2026-08-21 18:07:12 -07:00
Test 769e56d33d Add new file 2026-08-21 15:58:46 -07:00