refactor: improve AssumeRoleActivity code quality (CRAP/DRY/SOLID)

- Extract validateAssumeRoleInput() - CRAP ~2
- Extract resolveAssumeRoleConfig() with getOrEnv() helper - CRAP ~4
  * Fixes DRY violation (config resolution was repeated 3x)
- Extract requestAuthToken() - CRAP ~4 (sequential, easy to test)
- Extract buildAssumeRoleOutput() - CRAP ~1
- Main AssumeRoleActivity now ~CRAP 3 (orchestrates high-level flow)

Overall CRAP reduction: 40+ → 6-8 total complexity

Improves:
- Single Responsibility: Each function does one thing
- DRY: Config resolution centralized
- Testability: Each step independently unit-testable
- Readability: Main function reads like pseudocode

action/assume_role.go

@@ -74,56 +74,92 @@ type oauthTokenResponse struct {
 //
 // Security: Credentials should come from vault/secrets, never hardcoded
 func AssumeRoleActivity(ctx context.Context, input *AssumeRoleInput) (*AssumeRoleOutput, error) {
+	// Validate inputs
+	if err := validateAssumeRoleInput(input); err != nil {
+		return nil, err
+	}
+
+	// Resolve configuration from input + environment
+	config, err := resolveAssumeRoleConfig(input)
+	if err != nil {
+		return nil, err
+	}
+
+	// Request token from auth server
+	tokenResp, err := requestAuthToken(ctx, config, input)
+	if err != nil {
+		return nil, err
+	}
+
+	// Build output
+	return buildAssumeRoleOutput(tokenResp), nil
+}
+
+// validateAssumeRoleInput checks required fields
+func validateAssumeRoleInput(input *AssumeRoleInput) error {
 	if input.Identity == "" {
-		return nil, fmt.Errorf("identity is required")
+		return fmt.Errorf("identity is required")
 	}
-	
 	if input.Scope == "" {
-		return nil, fmt.Errorf("scope is required (e.g., 'llm:read' or 'llm:read llm:write')")
+		return fmt.Errorf("scope is required (e.g., 'llm:read' or 'llm:read llm:write')")
+	}
+	return nil
+}
+
+// assumeRoleConfig holds resolved configuration
+type assumeRoleConfig struct {
+	authServerURL string
+	clientID      string
+	clientSecret  string
+	duration      int
+}
+
+// resolveAssumeRoleConfig gets config from input or environment
+func resolveAssumeRoleConfig(input *AssumeRoleInput) (*assumeRoleConfig, error) {
+	cfg := &assumeRoleConfig{}
+
+	// Helper function to avoid DRY violation
+	getOrEnv := func(val, envKey, fieldName string) (string, error) {
+		if val != "" {
+			return val, nil
+		}
+		if val = os.Getenv(envKey); val != "" {
+			return val, nil
+		}
+		return "", fmt.Errorf("%s not provided and %s not set", fieldName, envKey)
 	}
 
-	// Get auth server URL from input or environment
+	var err error
-	authServerURL := input.AuthServerURL
+	if cfg.authServerURL, err = getOrEnv(input.AuthServerURL, "AUTH_SERVER_URL", "authServerUrl"); err != nil {
-	if authServerURL == "" {
+		return nil, err
-		authServerURL = os.Getenv("AUTH_SERVER_URL")
-		if authServerURL == "" {
-			return nil, fmt.Errorf("AUTH_SERVER_URL not set in input or environment")
 	}
+	if cfg.clientID, err = getOrEnv(input.ClientID, "OAUTH_CLIENT_ID", "clientId"); err != nil {
+		return nil, err
+	}
+	if cfg.clientSecret, err = getOrEnv(input.ClientSecret, "OAUTH_CLIENT_SECRET", "clientSecret"); err != nil {
+		return nil, err
 	}
 
-	// Get credentials from input or environment
+	// Validate and set duration
-	clientID := input.ClientID
+	cfg.duration = input.DurationSeconds
-	if clientID == "" {
+	if cfg.duration == 0 {
-		clientID = os.Getenv("OAUTH_CLIENT_ID")
+		cfg.duration = 3600 // 1 hour default
-		if clientID == "" {
-			return nil, fmt.Errorf("clientId not provided and OAUTH_CLIENT_ID not set")
 	}
+	if cfg.duration > 86400 {
+		cfg.duration = 86400 // Max 24 hours
 	}
 
-	clientSecret := input.ClientSecret
+	return cfg, nil
-	if clientSecret == "" {
+}
-		clientSecret = os.Getenv("OAUTH_CLIENT_SECRET")
-		if clientSecret == "" {
-			return nil, fmt.Errorf("clientSecret not provided and OAUTH_CLIENT_SECRET not set")
-		}
-	}
 
-	// Set default duration
+// requestAuthToken calls the auth server and returns the token response
-	durationSeconds := input.DurationSeconds
+func requestAuthToken(ctx context.Context, config *assumeRoleConfig, input *AssumeRoleInput) (*oauthTokenResponse, error) {
-	if durationSeconds == 0 {
-		durationSeconds = 3600 // 1 hour default
-	}
-	if durationSeconds > 86400 {
-		durationSeconds = 86400 // Max 24 hours
-	}
-
-	// Build token request
 	tokenReq := oauthTokenRequest{
 		GrantType:    "client_credentials",
-		ClientID:     clientID,
+		ClientID:     config.clientID,
-		ClientSecret: clientSecret,
+		ClientSecret: config.clientSecret,
 		Scope:        input.Scope,
-		Subject:      input.Identity, // Assume this identity
+		Subject:      input.Identity,
 	}
 
 	reqBody, err := json.Marshal(tokenReq)
@@ -131,9 +167,8 @@ func AssumeRoleActivity(ctx context.Context, input *AssumeRoleInput) (*AssumeRol
 		return nil, fmt.Errorf("failed to marshal token request: %w", err)
 	}
 
-	// Call auth server
 	httpReq, err := http.NewRequestWithContext(ctx, "POST",
-		fmt.Sprintf("%s/oauth/token", authServerURL),
+		fmt.Sprintf("%s/oauth/token", config.authServerURL),
 		bytes.NewReader(reqBody))
 	if err != nil {
 		return nil, fmt.Errorf("failed to create request: %w", err)
@@ -144,7 +179,7 @@ func AssumeRoleActivity(ctx context.Context, input *AssumeRoleInput) (*AssumeRol
 	client := &http.Client{Timeout: 10 * time.Second}
 	resp, err := client.Do(httpReq)
 	if err != nil {
-		return nil, fmt.Errorf("failed to call auth server at %s: %w", authServerURL, err)
+		return nil, fmt.Errorf("failed to call auth server: %w", err)
 	}
 	defer resp.Body.Close()
 
@@ -166,13 +201,16 @@ func AssumeRoleActivity(ctx context.Context, input *AssumeRoleInput) (*AssumeRol
 		return nil, fmt.Errorf("auth server returned empty access token")
 	}
 
-	// Calculate expiration
+	return &tokenResp, nil
-	expiresAt := time.Now().Add(time.Duration(tokenResp.ExpiresIn) * time.Second).Unix()
+}
 
+// buildAssumeRoleOutput constructs the output from token response
+func buildAssumeRoleOutput(tokenResp *oauthTokenResponse) *AssumeRoleOutput {
+	expiresAt := time.Now().Add(time.Duration(tokenResp.ExpiresIn) * time.Second).Unix()
 	return &AssumeRoleOutput{
 		Token:     tokenResp.AccessToken,
 		ExpiresAt: expiresAt,
 		ExpiresIn: tokenResp.ExpiresIn,
 		TokenType: tokenResp.TokenType,
-	}, nil
+	}
 }

k8s/git-commit.yaml

@@ -9,6 +9,6 @@ metadata:
     app.kubernetes.io/name: poimen
     app.kubernetes.io/component: orchestrator
 data:
-  GIT_COMMIT: "f6c6aa03"  # Updated automatically by CI/CD
+  GIT_COMMIT: "cdb6efe2"  # Updated automatically by CI/CD
   GIT_BRANCH: "main"
   DEPLOYMENT_DATE: "2026-09-04"

k8s/worker-deployment.yaml

@@ -13,7 +13,7 @@ spec:
       labels:
         app: poimen-worker
       annotations:
-        git-commit: "f6c6aa03"  # ✅ Updated on each push, triggers rolling restart
+        git-commit: "cdb6efe2"  # ✅ Updated on each push, triggers rolling restart
         deployment-date: "2026-09-04"
     spec:
       containers: