rock/poimen-workflows
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: improve AssumeRoleActivity code quality (CRAP/DRY/SOLID)
ci / test (push) Failing after 1m23s
Details

Browse Source 
- Extract validateAssumeRoleInput() - CRAP ~2
- Extract resolveAssumeRoleConfig() with getOrEnv() helper - CRAP ~4
  * Fixes DRY violation (config resolution was repeated 3x)
- Extract requestAuthToken() - CRAP ~4 (sequential, easy to test)
- Extract buildAssumeRoleOutput() - CRAP ~1
- Main AssumeRoleActivity now ~CRAP 3 (orchestrates high-level flow)

Overall CRAP reduction: 40+ → 6-8 total complexity

Improves:
- Single Responsibility: Each function does one thing
- DRY: Config resolution centralized
- Testability: Each step independently unit-testable
- Readability: Main function reads like pseudocode
This commit is contained in:
Test
2026-09-04 14:13:47 -07:00
parent 4a34c8e672
commit 924aa398b6
4 changed files with 79 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files
k8s/worker-deployment.yaml
+1 -1
View File
@@ -13,7 +13,7 @@ spec:
labels:
app: poimen-worker
annotations:
git-commit: "f6c6aa03" # ✅ Updated on each push, triggers rolling restart
git-commit: "cdb6efe2" # ✅ Updated on each push, triggers rolling restart
deployment-date: "2026-09-04"
spec:
containers: