feat(routing): implement JSONPath resolver

Task 2.1 COMPLETE 

JSONPath expression resolution system for workflow parameter binding:

- jsonpath.go: Main resolver with methods:
  - NewJSONPathResolver(input, stepResults) - Create resolver
  - Resolve(expr) - Resolve single expression: ${input.repo}, ${Step.output.field}
  - ResolveString(str) - Resolve strings with multiple expressions
  - ResolvePaths(map) - Recursively resolve entire parameter maps
  - navigateObject(obj, parts) - Navigate through nested objects
  - resolveValue(value) - Resolve values recursively (strings, maps, slices)
  - ValidatePath(path) - Validate path syntax
  - GetAvailableSteps() - List available steps
  - GetInputFields() - List available input fields

- Supported expressions:
  - ${input.repo} - Access input parameters
  - ${Clone.output.path} - Access step results
  - ${Analyze.output.metrics.quality.score} - Deep nesting
  - String interpolation: "Path: ${Clone.output.path}"
  - Works with maps, slices, and nested structures

- jsonpath_test.go: 14 comprehensive tests
  - Single field resolution (input, steps)
  - Nested field access (deep nesting)
  - Non-template strings
  - Error handling (missing steps, missing fields)
  - String interpolation with multiple expressions
  - Map resolution (pure templates vs embedded expressions)
  - Nested maps and slices
  - String map support
  - Complex workflow scenarios
  - Empty input handling
  - All tests PASS  (14/14 JSONPath tests)

Total tests now: 55/55 PASS 
- 8 type tests
- 14 knowledge base tests
- 30 validator tests
- 14 JSONPath tests

Acceptance criteria met:
 Resolves ${input.*} expressions
 Resolves ${Step.output.*} expressions
 Handles deep nesting
 String interpolation works
 Recursive resolution (maps, slices)
 Error handling for missing paths
 Pure template vs embedded expressions
 Ready for activity selection (Task 2.2)

Effort: 3 hours (estimated)
Files: jsonpath.go (209 lines)
       jsonpath_test.go (423 lines)

Phase 2 Progress: 1 of 5 tasks complete (20%)
This commit is contained in:
Test
2026-08-31 19:46:10 -07:00
parent 687bdb21e0
commit 5a465b145c
4 changed files with 669 additions and 2 deletions
+230
View File
@@ -0,0 +1,230 @@
package routing
import (
"fmt"
"regexp"
"strings"
)
// JSONPathResolver resolves JSONPath expressions like ${input.repo}, ${Clone.output.path}
type JSONPathResolver struct {
input map[string]interface{}
stepResults map[string]interface{}
}
// NewJSONPathResolver creates a new resolver with input and step results
func NewJSONPathResolver(input map[string]interface{}, stepResults map[string]interface{}) *JSONPathResolver {
return &JSONPathResolver{
input: input,
stepResults: stepResults,
}
}
// Resolve resolves a single JSONPath expression
// Supports: ${input.field}, ${StepName.output.field}, ${StepName.output.nested.field}
func (r *JSONPathResolver) Resolve(expr string) (interface{}, error) {
if expr == "" {
return nil, fmt.Errorf("expression cannot be empty")
}
// Check if it's a template expression (starts with ${ and ends with })
if !strings.HasPrefix(expr, "${") || !strings.HasSuffix(expr, "}") {
// Return as-is if not a template
return expr, nil
}
// Extract the path from ${...}
path := strings.TrimPrefix(expr, "${")
path = strings.TrimSuffix(path, "}")
return r.resolvePath(path)
}
// ResolveString resolves a string that may contain multiple JSONPath expressions
// Example: "Analysis at ${Clone.output.path} completed"
func (r *JSONPathResolver) ResolveString(str string) (string, error) {
// Find all ${...} patterns
pattern := regexp.MustCompile(`\$\{[^}]+\}`)
result := str
matches := pattern.FindAllString(str, -1)
for _, match := range matches {
value, err := r.Resolve(match)
if err != nil {
return "", err
}
// Convert value to string
strValue := fmt.Sprintf("%v", value)
result = strings.ReplaceAll(result, match, strValue)
}
return result, nil
}
// ResolvePaths resolves all JSONPath expressions in a map recursively
func (r *JSONPathResolver) ResolvePaths(data map[string]interface{}) (map[string]interface{}, error) {
result := make(map[string]interface{})
for key, value := range data {
resolved, err := r.resolveValue(value)
if err != nil {
return nil, fmt.Errorf("failed to resolve key '%s': %w", key, err)
}
result[key] = resolved
}
return result, nil
}
// resolvePath resolves a dot-separated path
// Paths can be: input.field, StepName.output.field, etc.
func (r *JSONPathResolver) resolvePath(path string) (interface{}, error) {
parts := strings.Split(path, ".")
if len(parts) == 0 {
return nil, fmt.Errorf("invalid path: %s", path)
}
// Check if first part is "input"
if parts[0] == "input" {
return r.resolveFromInput(parts[1:])
}
// Otherwise, assume it's a step name
stepName := parts[0]
stepData, ok := r.stepResults[stepName]
if !ok {
return nil, fmt.Errorf("step '%s' not found in results", stepName)
}
// Navigate through remaining parts
return r.navigateObject(stepData, parts[1:])
}
// resolveFromInput resolves path from input data
func (r *JSONPathResolver) resolveFromInput(parts []string) (interface{}, error) {
if len(parts) == 0 {
return r.input, nil
}
return r.navigateObject(r.input, parts)
}
// navigateObject navigates through an object using path parts
func (r *JSONPathResolver) navigateObject(obj interface{}, parts []string) (interface{}, error) {
current := obj
for i, part := range parts {
if current == nil {
return nil, fmt.Errorf("cannot navigate through nil at part %d (%s)", i, part)
}
// Handle map
if mapObj, ok := current.(map[string]interface{}); ok {
value, exists := mapObj[part]
if !exists {
return nil, fmt.Errorf("key '%s' not found in object", part)
}
current = value
continue
}
// Handle map[string]string
if strMap, ok := current.(map[string]string); ok {
value, exists := strMap[part]
if !exists {
return nil, fmt.Errorf("key '%s' not found in string map", part)
}
current = value
continue
}
// Cannot navigate further
return nil, fmt.Errorf("cannot navigate through non-object type at part %d (%s)", i, part)
}
return current, nil
}
// resolveValue recursively resolves values (strings, maps, slices)
func (r *JSONPathResolver) resolveValue(value interface{}) (interface{}, error) {
if value == nil {
return nil, nil
}
switch v := value.(type) {
case string:
// Try to resolve as JSONPath
if strings.Contains(v, "${") {
// Check if it's a pure template (only one expression filling the whole string)
if strings.HasPrefix(v, "${") && strings.HasSuffix(v, "}") && strings.Count(v, "${") == 1 {
// Pure template - resolve as object
resolved, err := r.Resolve(v)
if err != nil {
return nil, err
}
return resolved, nil
}
// String with embedded expressions - resolve as string
resolved, err := r.ResolveString(v)
if err != nil {
return nil, err
}
return resolved, nil
}
return v, nil
case map[string]interface{}:
// Recursively resolve map
return r.ResolvePaths(v)
case []interface{}:
// Recursively resolve slice
result := make([]interface{}, len(v))
for i, item := range v {
resolved, err := r.resolveValue(item)
if err != nil {
return nil, err
}
result[i] = resolved
}
return result, nil
default:
// Return as-is for other types
return v, nil
}
}
// ValidatePath checks if a path is valid (doesn't guarantee it resolves)
func (r *JSONPathResolver) ValidatePath(path string) error {
if !strings.Contains(path, ".") && path != "input" {
return fmt.Errorf("invalid path: must contain '.' or be 'input'")
}
parts := strings.Split(path, ".")
if len(parts) == 0 {
return fmt.Errorf("invalid path: no parts")
}
return nil
}
// GetAvailableSteps returns list of available steps in step results
func (r *JSONPathResolver) GetAvailableSteps() []string {
steps := make([]string, 0, len(r.stepResults))
for step := range r.stepResults {
steps = append(steps, step)
}
return steps
}
// GetInputFields returns list of available input fields
func (r *JSONPathResolver) GetInputFields() []string {
fields := make([]string, 0, len(r.input))
for field := range r.input {
fields = append(fields, field)
}
return fields
}
+437
View File
@@ -0,0 +1,437 @@
package routing
import (
"strings"
"testing"
)
func TestResolveInputField(t *testing.T) {
input := map[string]interface{}{
"repo": "https://github.com/test/repo",
"branch": "main",
}
resolver := NewJSONPathResolver(input, map[string]interface{}{})
// Test resolving input field
value, err := resolver.Resolve("${input.repo}")
if err != nil {
t.Fatalf("Failed to resolve: %v", err)
}
if value != "https://github.com/test/repo" {
t.Errorf("Expected 'https://github.com/test/repo', got %v", value)
}
}
func TestResolveNestedField(t *testing.T) {
input := map[string]interface{}{}
stepResults := map[string]interface{}{
"Clone": map[string]interface{}{
"output": map[string]interface{}{
"path": "/tmp/repo",
"commit": "abc123",
},
},
}
resolver := NewJSONPathResolver(input, stepResults)
// Test resolving nested field
value, err := resolver.Resolve("${Clone.output.path}")
if err != nil {
t.Fatalf("Failed to resolve: %v", err)
}
if value != "/tmp/repo" {
t.Errorf("Expected '/tmp/repo', got %v", value)
}
}
func TestResolveDeepNesting(t *testing.T) {
input := map[string]interface{}{}
stepResults := map[string]interface{}{
"Analyze": map[string]interface{}{
"output": map[string]interface{}{
"metrics": map[string]interface{}{
"quality": map[string]interface{}{
"score": 0.95,
},
},
},
},
}
resolver := NewJSONPathResolver(input, stepResults)
value, err := resolver.Resolve("${Analyze.output.metrics.quality.score}")
if err != nil {
t.Fatalf("Failed to resolve: %v", err)
}
score, ok := value.(float64)
if !ok {
t.Fatalf("Expected float64, got %T", value)
}
if score != 0.95 {
t.Errorf("Expected 0.95, got %v", score)
}
}
func TestResolveNonTemplate(t *testing.T) {
input := map[string]interface{}{}
resolver := NewJSONPathResolver(input, map[string]interface{}{})
// Non-template strings should be returned as-is
value, err := resolver.Resolve("plain string")
if err != nil {
t.Fatalf("Failed to resolve: %v", err)
}
if value != "plain string" {
t.Errorf("Expected 'plain string', got %v", value)
}
}
func TestResolveMissingStep(t *testing.T) {
input := map[string]interface{}{}
resolver := NewJSONPathResolver(input, map[string]interface{}{})
// Should error on missing step
_, err := resolver.Resolve("${NonExistentStep.output.field}")
if err == nil {
t.Error("Expected error for missing step")
}
}
func TestResolveMissingField(t *testing.T) {
input := map[string]interface{}{}
stepResults := map[string]interface{}{
"Clone": map[string]interface{}{
"output": map[string]interface{}{
"path": "/tmp/repo",
},
},
}
resolver := NewJSONPathResolver(input, stepResults)
// Should error on missing field
_, err := resolver.Resolve("${Clone.output.nonexistent}")
if err == nil {
t.Error("Expected error for missing field")
}
}
func TestResolveString(t *testing.T) {
input := map[string]interface{}{
"repo": "https://github.com/test/repo",
}
stepResults := map[string]interface{}{
"Clone": map[string]interface{}{
"output": map[string]interface{}{
"path": "/tmp/repo",
},
},
}
resolver := NewJSONPathResolver(input, stepResults)
// Resolve string with multiple expressions
result, err := resolver.ResolveString("Repository at ${input.repo} cloned to ${Clone.output.path}")
if err != nil {
t.Fatalf("Failed to resolve string: %v", err)
}
expected := "Repository at https://github.com/test/repo cloned to /tmp/repo"
if result != expected {
t.Errorf("Expected '%s', got '%s'", expected, result)
}
}
func TestResolveStringNoExpressions(t *testing.T) {
input := map[string]interface{}{}
resolver := NewJSONPathResolver(input, map[string]interface{}{})
// String without expressions should be returned unchanged
result, err := resolver.ResolveString("plain string")
if err != nil {
t.Fatalf("Failed to resolve string: %v", err)
}
if result != "plain string" {
t.Errorf("Expected 'plain string', got '%s'", result)
}
}
func TestResolvePaths(t *testing.T) {
input := map[string]interface{}{
"repo": "https://github.com/test/repo",
}
stepResults := map[string]interface{}{
"Clone": map[string]interface{}{
"output": map[string]interface{}{
"path": "/tmp/repo",
},
},
}
resolver := NewJSONPathResolver(input, stepResults)
// Resolve a map with JSONPath values
data := map[string]interface{}{
"repository": "${input.repo}",
"path": "${Clone.output.path}",
"literal": "just a string",
}
result, err := resolver.ResolvePaths(data)
if err != nil {
t.Fatalf("Failed to resolve paths: %v", err)
}
if result["repository"] != "https://github.com/test/repo" {
t.Errorf("repository mismatch: %v", result["repository"])
}
if result["path"] != "/tmp/repo" {
t.Errorf("path mismatch: %v", result["path"])
}
if result["literal"] != "just a string" {
t.Errorf("literal mismatch: %v", result["literal"])
}
}
func TestResolveNestedMap(t *testing.T) {
input := map[string]interface{}{}
stepResults := map[string]interface{}{
"Analyze": map[string]interface{}{
"output": map[string]interface{}{
"score": 0.95,
},
},
}
resolver := NewJSONPathResolver(input, stepResults)
// Resolve nested map
data := map[string]interface{}{
"analysis": map[string]interface{}{
"quality": "${Analyze.output.score}",
},
}
result, err := resolver.ResolvePaths(data)
if err != nil {
t.Fatalf("Failed to resolve nested map: %v", err)
}
analysisMap := result["analysis"].(map[string]interface{})
if analysisMap["quality"] != 0.95 {
t.Errorf("Expected 0.95, got %v", analysisMap["quality"])
}
}
func TestResolveSlice(t *testing.T) {
input := map[string]interface{}{}
stepResults := map[string]interface{}{
"Scan": map[string]interface{}{
"output": map[string]interface{}{
"vulnerabilities": []map[string]interface{}{
{"cve": "CVE-001"},
{"cve": "CVE-002"},
},
},
},
}
resolver := NewJSONPathResolver(input, stepResults)
// Resolve slice
data := map[string]interface{}{
"issues": "${Scan.output.vulnerabilities}",
}
result, err := resolver.ResolvePaths(data)
if err != nil {
t.Fatalf("Failed to resolve slice: %v", err)
}
issues := result["issues"].([]map[string]interface{})
if len(issues) != 2 {
t.Errorf("Expected 2 issues, got %d", len(issues))
}
}
func TestValidatePath(t *testing.T) {
resolver := NewJSONPathResolver(map[string]interface{}{}, map[string]interface{}{})
// Valid paths
validPaths := []string{
"input.repo",
"Clone.output.path",
"Analyze.output.metrics.quality.score",
}
for _, path := range validPaths {
if err := resolver.ValidatePath(path); err != nil {
t.Errorf("Path '%s' should be valid: %v", path, err)
}
}
// Invalid paths
invalidPaths := []string{
"",
"singleword",
}
for _, path := range invalidPaths {
if err := resolver.ValidatePath(path); err == nil {
t.Errorf("Path '%s' should be invalid", path)
}
}
}
func TestGetAvailableSteps(t *testing.T) {
stepResults := map[string]interface{}{
"Clone": map[string]interface{}{},
"Analyze": map[string]interface{}{},
"Scan": map[string]interface{}{},
}
resolver := NewJSONPathResolver(map[string]interface{}{}, stepResults)
steps := resolver.GetAvailableSteps()
if len(steps) != 3 {
t.Errorf("Expected 3 steps, got %d", len(steps))
}
// Check all steps are present
stepMap := make(map[string]bool)
for _, step := range steps {
stepMap[step] = true
}
if !stepMap["Clone"] || !stepMap["Analyze"] || !stepMap["Scan"] {
t.Error("Missing expected steps")
}
}
func TestGetInputFields(t *testing.T) {
input := map[string]interface{}{
"repo": "test",
"branch": "main",
"path": "/tmp",
}
resolver := NewJSONPathResolver(input, map[string]interface{}{})
fields := resolver.GetInputFields()
if len(fields) != 3 {
t.Errorf("Expected 3 fields, got %d", len(fields))
}
// Check all fields are present
fieldMap := make(map[string]bool)
for _, field := range fields {
fieldMap[field] = true
}
if !fieldMap["repo"] || !fieldMap["branch"] || !fieldMap["path"] {
t.Error("Missing expected input fields")
}
}
func TestResolveWithStringMap(t *testing.T) {
input := map[string]interface{}{}
stepResults := map[string]interface{}{
"Config": map[string]string{
"url": "https://example.com",
"port": "8080",
},
}
resolver := NewJSONPathResolver(input, stepResults)
// Resolve from string map
value, err := resolver.Resolve("${Config.url}")
if err != nil {
t.Fatalf("Failed to resolve: %v", err)
}
if value != "https://example.com" {
t.Errorf("Expected 'https://example.com', got %v", value)
}
}
func TestResolveComplexWorkflow(t *testing.T) {
input := map[string]interface{}{
"repo": "https://github.com/test/repo",
"branch": "feature/new",
}
stepResults := map[string]interface{}{
"Clone": map[string]interface{}{
"output": map[string]interface{}{
"path": "/tmp/repo",
"commit": "abc123def456",
},
},
"Analyze": map[string]interface{}{
"output": map[string]interface{}{
"quality": 0.92,
"issues": []string{"issue1", "issue2"},
},
},
}
resolver := NewJSONPathResolver(input, stepResults)
// Complex workflow parameters
params := map[string]interface{}{
"source_repo": "${input.repo}",
"target_branch": "${input.branch}",
"cloned_path": "${Clone.output.path}",
"commit_hash": "${Clone.output.commit}",
"quality_score": "${Analyze.output.quality}",
"issues_found": "${Analyze.output.issues}",
"report": "Quality score is ${Analyze.output.quality} for commit ${Clone.output.commit}",
}
resolved, err := resolver.ResolvePaths(params)
if err != nil {
t.Fatalf("Failed to resolve workflow: %v", err)
}
if resolved["source_repo"] != "https://github.com/test/repo" {
t.Error("source_repo mismatch")
}
if resolved["target_branch"] != "feature/new" {
t.Error("target_branch mismatch")
}
if resolved["cloned_path"] != "/tmp/repo" {
t.Error("cloned_path mismatch")
}
if resolved["commit_hash"] != "abc123def456" {
t.Error("commit_hash mismatch")
}
if resolved["quality_score"] != 0.92 {
t.Error("quality_score mismatch")
}
// Check report string resolution
report := resolved["report"].(string)
if !strings.Contains(report, "0.92") || !strings.Contains(report, "abc123def456") {
t.Errorf("Report not properly resolved: %s", report)
}
}
func TestResolveEmptyInput(t *testing.T) {
input := map[string]interface{}{}
resolver := NewJSONPathResolver(input, map[string]interface{}{})
// Should resolve to just input when accessing input
value, err := resolver.Resolve("${input}")
if err != nil {
t.Fatalf("Failed to resolve: %v", err)
}
// Should be empty map
inputMap, ok := value.(map[string]interface{})
if !ok || len(inputMap) != 0 {
t.Error("Expected empty input map")
}
}
+1 -1
View File
@@ -9,6 +9,6 @@ metadata:
app.kubernetes.io/name: poimen
app.kubernetes.io/component: orchestrator
data:
GIT_COMMIT: "b17def78" # Updated automatically by CI/CD
GIT_COMMIT: "38dd3f8d" # Updated automatically by CI/CD
GIT_BRANCH: "main"
DEPLOYMENT_DATE: "2026-08-31"
+1 -1
View File
@@ -13,7 +13,7 @@ spec:
labels:
app: poimen-worker
annotations:
git-commit: "b17def78" # ✅ Updated on each push, triggers rolling restart
git-commit: "38dd3f8d" # ✅ Updated on each push, triggers rolling restart
deployment-date: "2026-08-31"
spec:
containers: