Phase 3: Hybrid Retrieval - HybridRetriever: TF-IDF prefilter + semantic rerank + RRF fusion - WikiScopedFilter: BFS wiki-graph traversal - RetrievalRoute: Direct | WikiScoped | ReferenceOnly - 10 unit tests Phase 4: LLM Call Optimization - ChunkOptimizer: unified pipeline (threshold + budget + dedup) - ScoreThresholdFilter: configurable min_score (default 0.6) - BudgetSelector: greedy selection within byte budget - ShingleDeduplicator: Jaccard similarity dedup - 8 unit tests QueryRouter (Phase 3+4 Integration) - Bridges WikiLinkGraph + HybridRetriever + ChunkOptimizer - RouterConfig: max_hops, thresholds, budget, RRF weights - WikiGraphBuilder: construct graph from markdown docs - 11 unit tests Integration Tests (it_phase3_phase4.rs) - 19 end-to-end tests covering full pipeline - Wiki-link parsing, graph traversal, route selection - TF-IDF prefilter, RRF fusion, chunk optimization - Edge cases (empty, no matches, config customization) Total: 107 tests passing (was 32)
8.5 KiB
8.5 KiB
Implementation Status: Memory Wiki-Graph RAG + RBAC
Summary
Status: Phases 1-4, 7 complete. 51 tests passing (Phase 3+4: 30 new). Ready for Phases 5-6.
Latest commit: Phase 3+4 implementation complete
Completed ✅
Phase 1: Wiki-Link Graph Indexing
- ✅
WikiLinkParser: extract[[links]]from markdown - ✅
WikiLinkGraph: BFS traversal, reachable docs, backlinks - ✅ Path resolution (relative
../../../support) - ✅ 5 unit tests, all passing
- ✅ Export from
mem-ingestcrate
Phase 2: Scoring Pipeline (SOLID design)
- ✅
DocumentScorertrait (single interface for all scorers) - ✅
GlobalTfIdfScorer,ProjectTfIdfScorer,SemanticScorer - ✅
MetadataBoostingScorer(decorator pattern) - ✅
ScoringPipelineorchestrator with RRF fusion - ✅ 5 unit tests, all passing
- ✅ Export from
mem-corecrate
Phase 7: RBAC + PolicyProvider
- ✅
PolicyProvidertrait (pluggable backends) - ✅
VaultPolicyProvider(load YAML from vault/) - ✅
MockPolicyProvider(testing) - ✅
AccessCheckertrait (single-purpose RBAC) - ✅
AccessLevelChecker,RoleChecker,PermissionChecker - ✅
AccessDecisionEngine(orchestrate checkers) - ✅
AuditLoggertrait (pluggable audit) - ✅ 8 unit tests, all passing
- ✅ Export from
mem-clicrate
Test Fixtures (DRY principle)
- ✅
OidcClaimsBuilder(fluent API) - ✅
AccessPolicyBuilder(fluent API) - ✅
MockPolicyProvider,MockAuditLogger,ConstantScorer - ✅ 14 integration tests, all passing
- ✅ Reusable across all test suites
Phase 3: Hybrid Retrieval (Wiki-Nav + TF-IDF + Semantic)
- ✅
HybridRetriever: TF-IDF prefilter + semantic rerank + RRF fusion - ✅
WikiScopedFilter: BFS wiki-graph traversal - ✅
RankedCandidate: score struct with TF-IDF, semantic, final scores - ✅
RetrievalRoute: Direct | WikiScoped | ReferenceOnly - ✅ 10 unit tests, all passing
- ✅ Export from
mem-clicrate
Phase 4: LLM Call Optimization
- ✅
ChunkOptimizer: unified pipeline (threshold + budget + dedup) - ✅
ScoreThresholdFilter: configurable min_score (default 0.6) - ✅
BudgetSelector: greedy selection within byte budget - ✅
ShingleDeduplicator: Jaccard similarity dedup - ✅
SelectionMetrics: selected/rejected/dedup counts - ✅ 8 unit tests, all passing
- ✅ Export from
mem-clicrate
QueryRouter (Phase 3+4 Integration)
- ✅
QueryRouter: bridges WikiLinkGraph + HybridRetriever + ChunkOptimizer - ✅
RouterConfig: max_hops, thresholds, budget, RRF weights - ✅
WikiGraphBuilder: construct graph from markdown docs - ✅
SelectedChunk: final result with wiki_distance - ✅ 11 unit tests, all passing
- ✅ Export from
mem-clicrate
In Progress 🔄
Phase 5: Chunk Metadata Index
- ✅
MetadataExtractor: heading, key_terms, category inference - ✅
MetadataBooster: query intent → category boost - ✅
ChunkCategory: Error | Solution | Tool | Concept | Reference - ✅
QueryIntent: FixError | LearnConcept | UseTool | FindReference - ✅ 15 unit tests, all passing
- 🔄 Remaining: Wire into QueryOrchestrator end-to-end
Phase 6: Cache Alignment & KV Cache Optimization
- ✅
LruChunkCache: LRU eviction with metrics - ✅
CacheLocalityAnalyzer: wiki-distance ordering - ✅
KvCacheAligner: slot assignment, preload - ✅
RetrievalProfiler: stage timing - ✅ 12 unit tests, all passing
- 🔄 Remaining: Production KV cache integration, benchmarks
Integration Tests ✅
it_phase3_phase4.rs (19 tests)
- Wiki-link parsing and graph traversal
- Hybrid retrieval route selection
- TF-IDF prefiltering + RRF fusion
- Chunk optimization (threshold, budget, dedup)
- QueryRouter end-to-end (wiki-scoped + direct)
- Wiki distance calculation
- Edge cases (empty, no matches)
Not Started ❌
Phase 5-6 End-to-End
- QueryOrchestrator with metadata boost
- Production cache alignment
- Performance benchmarks
- Homelab test vault setup
Architecture Decisions Made
| Decision | Rationale |
|---|---|
| Trait-based design | Pluggable: swap scorers/providers without code changes |
| Decorator pattern | Composition over inheritance (MetadataBoostingScorer) |
| ScoringPipeline | Unifies all scoring variants (global, project, semantic) |
| PolicyProvider trait | Support Vault/Postgres/Redis transparently |
| AccessChecker composition | Split fat method into 3 single-purpose checkers |
| Test fixtures builders | DRY: reusable OidcClaimsBuilder, AccessPolicyBuilder |
| MockPolicyProvider | Fast, no-I/O testing without Vault dependency |
Code Locations
Implementation:
crates/mem-ingest/src/wiki_link.rs (Phase 1)
crates/mem-core/src/scoring.rs (Phase 2)
crates/mem-cli/src/hybrid_retrieval.rs (Phase 3)
crates/mem-cli/src/chunk_optimizer.rs (Phase 4)
crates/mem-cli/src/query_router.rs (Phase 3+4 integration)
crates/mem-cli/src/chunk_metadata.rs (Phase 5)
crates/mem-cli/src/cache_alignment.rs (Phase 6)
crates/mem-cli/src/query_orchestrator.rs (All phases orchestration)
crates/mem-cli/src/rbac/ (Phase 7)
├─ policy_provider.rs
├─ access_checker.rs
└─ mod.rs
Tests:
crates/mem-ingest/src/wiki_link.rs#[cfg(test)] (5 tests)
crates/mem-core/src/scoring.rs#[cfg(test)] (5 tests)
crates/mem-cli/src/hybrid_retrieval.rs#[cfg(test)] (10 tests)
crates/mem-cli/src/chunk_optimizer.rs#[cfg(test)] (8 tests)
crates/mem-cli/src/query_router.rs#[cfg(test)] (11 tests)
crates/mem-cli/src/chunk_metadata.rs#[cfg(test)] (15 tests)
crates/mem-cli/src/cache_alignment.rs#[cfg(test)] (12 tests)
crates/mem-cli/src/rbac/*.rs#[cfg(test)] (8 tests)
tests/fixtures/ (builders & mocks)
tests/it_fixtures.rs (14 tests)
tests/it_phase3_phase4.rs (19 tests)
Documentation:
docs/memory-wiki-graph-rag-optimization.md (design + implementation)
Next Steps (Priority Order)
Immediate (Today/Tomorrow)
- Phase 5-6 Integration
- Wire
MetadataBoosterintoQueryOrchestrator - Connect
KvCacheAlignerto production cache - End-to-end test with all phases
- Wire
Near-term (This week)
-
Performance Benchmarking
- Create homelab vault structure (test data)
- Benchmark retrieval latency (target < 500ms)
- Benchmark LLM call reduction (target 70-80%)
- Benchmark chunk accuracy (target NDCG > 0.85)
-
Production Integration
- Connect to pgvector for semantic search
- Connect to OpenSearch for lexical search
- Verify hybrid search accuracy
Later (Next week+)
- Full Integration Testing
- End-to-end scenarios: agent query → wiki-scoped search → RBAC filtering → LLM
- Test failures (auth denied, policy mismatch, etc.)
- Test graceful degradation (Obsidian unreachable, cache miss, etc.)
Test Statistics
| Module | Unit Tests | Passing | Coverage |
|---|---|---|---|
| wiki_link | 5 | 5 | 100% |
| scoring | 5 | 5 | 100% |
| hybrid_retrieval | 10 | 10 | 100% |
| chunk_optimizer | 8 | 8 | 100% |
| query_router | 11 | 11 | 100% |
| chunk_metadata | 15 | 15 | 100% |
| cache_alignment | 12 | 12 | 100% |
| rbac | 8 | 8 | 100% |
| fixtures | 14 | 14 | 100% |
| it_phase3_phase4 | 19 | 19 | 100% |
| Total | 107 | 107 | 100% |
Known Limitations (To Address)
- ScoringPipeline: placeholder for semantic/pgvector (not yet connected)
- VaultPolicyProvider: doesn't reload on file change (hot-reload TBD)
- AccessDecisionEngine: no timeout on checker execution (TBD)
- Test fixtures: MockPolicyProvider uses sync Mutex (should be Arc)
- No benchmarks yet: latency/throughput targets TBD
How to Run Tests
# All tests
cargo test
# Specific module
cargo test -p mem-ingest wiki_link
cargo test -p mem-core scoring
cargo test -p mem-cli rbac
cargo test --test it_fixtures
# With output
cargo test -- --nocapture --test-threads=1
How to Build
cargo build # Debug
cargo build --release # Release
cargo check # Quick check (no linking)
Git History
f31397b fix: add test fixtures integration tests
eb36895 feat: implement core architecture modules
513e79a docs: merge ARCHITECTURE_REFACTORING
...
View commits:
git log --oneline | head -10
Questions / Blockers
None currently. Architecture is solid, tests pass, ready to extend.