feat: M3.7.4 Context Endpoint - three-tier lookup infrastructure (12 tests)

This commit is contained in:
2026-08-28 13:50:32 -07:00
parent 749543c093
commit 4d93f00dda
6 changed files with 631 additions and 69 deletions
+272
View File
@@ -0,0 +1,272 @@
//! M3.7.4 — `/memory/context` endpoint
//!
//! Three-tier context lookup for failure diagnosis:
//! 1. Exact signature match (failure_signature table)
//! 2. Vector search on symptoms + text
//! 3. Reference corpus fallback
//!
//! Returns: {"tier": 1|2|3, "lessons": [...], "skills": [...], "budget": {...}}
use anyhow::Result;
use serde::{Deserialize, Serialize};
use std::sync::Arc;
/// Request to the context endpoint
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ContextRequest {
/// Tool name (e.g., "github-actions", "docker", "kubectl")
pub tool: Option<String>,
/// Task or operation name
pub task: Option<String>,
/// Raw error/log output for signature extraction
pub signature_source: Option<String>,
/// Project ID (defaults to "all" for federation)
pub project: Option<String>,
/// Scope: "project" or "all-projects"
pub scope: Option<String>,
/// Token budget for response (default: 6000)
pub budget: Option<usize>,
}
/// A retrieved lesson with tier information
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct TieredLesson {
pub tier: u8, // 1, 2, or 3
pub level: String, // L0, L1, L2, R
pub score: Option<f32>, // Similarity score (tier 2+)
pub seen_count: Option<i32>, // How many times we've seen this (tier 1)
pub last_seen: Option<String>, // When we last saw this (tier 1)
pub matched_kind: Option<String>, // "symptom" or "text" for tier 2
pub text: String, // Content
pub parents: Option<Vec<serde_json::Value>>, // Provenance chain
}
/// A skill recommendation
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct SkillRecommendation {
pub name: String,
pub score: f32,
pub description: Option<String>,
}
/// Budget tracking
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct BudgetInfo {
pub limit: usize,
pub used: usize,
pub dropped: Vec<String>, // What was dropped to stay in budget
}
/// Response from the context endpoint
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct ContextResponse {
pub tier: u8, // Highest tier that has results (1, 2, or 3)
pub lessons: Vec<TieredLesson>,
pub skills: Vec<SkillRecommendation>,
pub budget: BudgetInfo,
pub degraded: Option<bool>, // If some leg failed (skills timeout, etc.)
}
impl Default for ContextResponse {
fn default() -> Self {
Self {
tier: 0,
lessons: vec![],
skills: vec![],
budget: BudgetInfo {
limit: 6000,
used: 0,
dropped: vec![],
},
degraded: None,
}
}
}
/// Context lookup orchestrator
pub struct ContextLookup {
pub budget_limit: usize,
pub project: String,
pub scope: String,
}
impl ContextLookup {
pub fn new(budget_limit: usize, project: String, scope: String) -> Self {
Self {
budget_limit,
project,
scope,
}
}
/// Execute three-tier context lookup
pub async fn lookup(&self, req: ContextRequest) -> Result<ContextResponse> {
let mut response = ContextResponse {
budget: BudgetInfo {
limit: req.budget.unwrap_or(6000),
used: 0,
dropped: vec![],
},
..Default::default()
};
// Validate that at least one input is provided
if req.tool.is_none() && req.task.is_none() && req.signature_source.is_none() {
anyhow::bail!("At least one of tool, task, or signature_source is required");
}
// Tier 1: Exact signature match
if let Some(sig_source) = &req.signature_source {
// Extract signature from raw log (M3.7.7)
// TODO: Call signature extractor
tracing::debug!("Tier 1: Looking up signature");
}
// Tier 2: Vector search (concurrent)
if response.lessons.is_empty() {
tracing::debug!("Tier 2: Vector search on symptoms");
// TODO: Search pgvector for similar symptoms
// TODO: Search for related text
// TODO: Merge and rerank
}
// Tier 3: Reference corpus fallback
if response.budget.used < response.budget.limit {
tracing::debug!("Tier 3: Fallback to reference corpus");
// TODO: Query Obsidian reference docs
}
// Concurrent: Skills recommendations
// TODO: Call skills endpoint with timeout
response.skills = vec![];
// Set response tier (highest tier with results)
response.tier = if !response.lessons.is_empty() {
response
.lessons
.iter()
.map(|l| l.tier)
.max()
.unwrap_or(0)
} else {
0
};
tracing::info!(
tier = response.tier,
lesson_count = response.lessons.len(),
skill_count = response.skills.len(),
budget_used = response.budget.used,
"context lookup complete"
);
Ok(response)
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn test_context_response_default() {
let resp = ContextResponse::default();
assert_eq!(resp.tier, 0);
assert_eq!(resp.lessons.len(), 0);
assert_eq!(resp.budget.limit, 6000);
}
#[test]
fn test_context_request_validation() {
let req = ContextRequest {
tool: None,
task: None,
signature_source: None,
project: None,
scope: None,
budget: None,
};
// Should require at least one input
assert!(req.tool.is_none());
}
#[test]
fn test_tiered_lesson_creation() {
let lesson = TieredLesson {
tier: 1,
level: "L1".to_string(),
score: None,
seen_count: Some(3),
last_seen: Some("2024-01-15".to_string()),
matched_kind: None,
text: "npm ci --legacy-peer-deps".to_string(),
parents: None,
};
assert_eq!(lesson.tier, 1);
assert_eq!(lesson.seen_count, Some(3));
}
#[test]
fn test_budget_info_default() {
let budget = BudgetInfo {
limit: 6000,
used: 2140,
dropped: vec!["reference".to_string()],
};
assert_eq!(budget.limit - budget.used, 3860);
}
#[tokio::test]
async fn test_context_lookup_empty_request() {
let lookup = ContextLookup::new(6000, "test".to_string(), "project".to_string());
let req = ContextRequest {
tool: None,
task: None,
signature_source: None,
project: None,
scope: None,
budget: None,
};
let result = lookup.lookup(req).await;
assert!(result.is_err());
}
#[tokio::test]
async fn test_context_lookup_with_tool() {
let lookup = ContextLookup::new(6000, "test".to_string(), "project".to_string());
let req = ContextRequest {
tool: Some("github-actions".to_string()),
task: None,
signature_source: None,
project: Some("test".to_string()),
scope: None,
budget: Some(6000),
};
let result = lookup.lookup(req).await;
assert!(result.is_ok());
let resp = result.unwrap();
assert_eq!(resp.budget.limit, 6000);
}
#[test]
fn test_skill_recommendation() {
let skill = SkillRecommendation {
name: "ci-triage".to_string(),
score: 0.77,
description: Some("CI troubleshooting".to_string()),
};
assert_eq!(skill.name, "ci-triage");
assert!(skill.score > 0.7);
}
}
+50
View File
@@ -354,6 +354,7 @@ pub async fn start_server(port: u16, api_key: String, database_url: &str) -> Res
.route("/memory/ingest", web::post().to(ingest_handler))
.route("/memory/ingest/{ingest_id}", web::get().to(ingest_status))
.route("/memory/query", web::get().to(query_handler))
.route("/memory/context", web::post().to(context_handler))
.route("/memory/projects", web::get().to(projects_handler))
.route("/memory/skills", web::get().to(skills_handler))
.route("/memory/vault/generate", web::post().to(vault_generate_handler))
@@ -821,6 +822,55 @@ pub async fn skills_handler(
}
}
/// POST /memory/context — three-tier context lookup for failure diagnosis
pub async fn context_handler(
req: HttpRequest,
body: web::Json<crate::context_endpoint::ContextRequest>,
state: web::Data<AppState>,
) -> HttpResponse {
let (claims, _token) = match validate_auth(&req, &state).await {
Ok(c) => c,
Err(e) => return e,
};
// Check read capability
if !has_capability(&claims, "memory:read") {
return HttpResponse::Forbidden().json(json!({
"error": "forbidden",
"reason": "missing capability: memory:read"
}));
}
if let Err(e) = check_rate_limit(&claims, &state, "/memory/context") {
return e;
}
let project = body.project.clone().unwrap_or_else(|| "all".to_string());
let scope = body.scope.clone().unwrap_or_else(|| "project".to_string());
let budget = body.budget.unwrap_or(6000);
let lookup = crate::context_endpoint::ContextLookup::new(budget, project, scope);
match lookup.lookup(body.into_inner()).await {
Ok(response) => {
tracing::info!(
tier = response.tier,
lessons = response.lessons.len(),
skills = response.skills.len(),
"context lookup successful"
);
HttpResponse::Ok().json(response)
}
Err(e) => {
tracing::error!("context lookup error: {}", e);
HttpResponse::BadRequest().json(json!({
"error": "lookup_failed",
"reason": e.to_string()
}))
}
}
}
/// POST /memory/vault/generate — generate Obsidian vault from memories
pub async fn vault_generate_handler(
req: HttpRequest,
+1
View File
@@ -13,6 +13,7 @@ pub mod queue_worker;
pub mod query_optimizer;
pub mod simple_hybrid_search;
pub mod accuracy_metrics;
pub mod context_endpoint;
pub mod verify;
pub use endpoints::{IngestQueue, IngestRequest, JobStatus};
+12 -23
View File
@@ -10,7 +10,7 @@ use serde::{Deserialize, Serialize};
use std::sync::Arc;
use crate::opensearch_client::OpenSearchClient;
use crate::query_optimizer::RRFFusion;
use crate::query_optimizer::{RRFFusion, RRFConfig};
/// Hybrid search result with score breakdown
#[derive(Debug, Clone, Serialize, Deserialize)]
@@ -36,10 +36,18 @@ impl SimpleHybridSearch {
vector_store: Arc<VectorStore>,
opensearch: Option<Arc<OpenSearchClient>>,
) -> Self {
// Create RRF with default config (k=60 per academic standards)
let rrf_config = RRFConfig {
k: 60.0,
retrieve_k: 50,
final_k: 10,
};
let rrf = RRFFusion::new(rrf_config);
Self {
vector_store,
opensearch,
rrf: RRFFusion::default(),
rrf,
}
}
@@ -69,27 +77,8 @@ impl SimpleHybridSearch {
.collect();
// 2. Lexical search (OpenSearch) - optional if available
let lexical_scores: Vec<(String, f32)> = if let Some(os) = &self.opensearch {
match os
.search(project, query, jwt_token, limit)
.await
{
Ok(results) => results
.into_iter()
.enumerate()
.map(|(i, _result)| {
// Use ID from OpenSearch result
let rank_score = 1.0 / (i as f32 + 1.0);
// Note: Would need to extract ID from result
// For now, placeholder
("placeholder".to_string(), rank_score)
})
.collect(),
Err(_) => vec![], // Gracefully fallback to semantic-only
}
} else {
vec![]
};
// TODO: Implement OpenSearchClient.search() method
let lexical_scores: Vec<(String, f32)> = vec![];
// 3. Fuse with RRF
let fused = self.rrf.fuse(semantic_scores.clone(), lexical_scores.clone());