This commit is contained in:
@@ -33,3 +33,15 @@ Client Service Pod N ----/ ↓
|
||||
- Horizontal scaling: add more `kmsvc` service replicas—Kafka rebalances automatically
|
||||
- HA: Redis Sentinel/Cluster recommended for production (design.md §9) — currently standalone
|
||||
- Monitoring: Kafka consumer-group lag, Redis pending/inflight keys, visibility timeouts
|
||||
|
||||
## Temporal Namespace Registration — Always Automatic, Never Manual
|
||||
|
||||
**Never manually run `temporal operator namespace create` (or the CLI/UI equivalent) for a namespace that a Queue's `temporal.io/namespace` label will reference.** `queue-operator`'s `reconcileTemporalWorker` (`internal/operator/queue_controller.go`) registers the Temporal namespace itself — idempotently, via `TemporalNamespaceRegisterer.RegisterNamespace` (`internal/operator/temporal_namespace.go`, real impl in `internal/temporal/client.go`) — before creating the `TemporalWorker` CR. This runs on every reconcile of every Queue carrying that label, so the namespace and its worker always exist together.
|
||||
|
||||
**The only steps to bring up a new Temporal namespace + worker are:**
|
||||
1. Apply a `Queue` CR with `metadata.labels["temporal.io/namespace"] = "<namespace>"`.
|
||||
2. That's it. `queue-operator` registers the namespace, creates `TemporalWorker/worker-<namespace>` in the `temporal` namespace, and its backing Deployment.
|
||||
|
||||
**Why this matters:** before this existed, a Queue's `temporal.io/namespace` label was trusted as-is with no verification — a typo'd or never-registered namespace silently produced a worker pod polling a namespace that doesn't exist, with no error surfaced anywhere until someone noticed workflows never executing. Manually pre-creating the namespace masks this — don't do it, let the operator own it.
|
||||
|
||||
One `TemporalWorker` per Temporal namespace serves *all* Queues labeled with that namespace (not one worker per Queue) — see the type doc on `TemporalWorkerSpec` in `apis/kmsvc/v1/temporalworker_types.go`.
|
||||
|
||||
@@ -0,0 +1,14 @@
|
||||
apiVersion: kmsvc.io/v1
|
||||
kind: Queue
|
||||
metadata:
|
||||
name: agent-worker-queue
|
||||
namespace: sqs
|
||||
labels:
|
||||
temporal.io/namespace: production
|
||||
spec:
|
||||
visibilityTimeoutSeconds: 30
|
||||
messageRetentionPeriodSeconds: 345600
|
||||
maxReceiveCount: 5
|
||||
partitionsPerShard: 1
|
||||
minShards: 1
|
||||
maxShards: 1
|
||||
Reference in New Issue
Block a user