rock/homelab
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: always re-register runner to keep labels in sync #2

Merged
rock merged 1 commits from fix/ci-runners-and-dns into main 2026-09-07 05:27:32 +00:00
Conversation 0 Commits 1 Files Changed 1
+5 -1
rock commented 2026-09-07 05:24:06 +00:00
Owner
Copy Link
Copy Source

Problem

Init container skips registration if .runner file exists on PVC:

test -f /data/.runner || forgejo-runner register ...

This means changing runner labels in values.yaml (e.g. the label image fix from PR #1) has no effect until PVCs are manually deleted — not GitOps-friendly.

Fix

Always delete .runner and re-register on every pod start:

rm -f /data/.runner
forgejo-runner register --no-interactive ...

Labels now stay in sync with values.yaml automatically. ArgoCD syncs → pods restart → init re-registers with current labels.

Files Changed

  • k8s/infra/forgejo-runner/templates/deployment.yaml (init container logic)

After Merge

ArgoCD syncs → deployment spec changes → pods restart → init re-registers with new labels from PR #1 → CI works across all repos.

## Problem Init container skips registration if `.runner` file exists on PVC: ``` test -f /data/.runner || forgejo-runner register ... ``` This means changing runner labels in `values.yaml` (e.g. the label image fix from PR #1) has **no effect** until PVCs are manually deleted — not GitOps-friendly. ## Fix Always delete `.runner` and re-register on every pod start: ``` rm -f /data/.runner forgejo-runner register --no-interactive ... ``` Labels now stay in sync with `values.yaml` automatically. ArgoCD syncs → pods restart → init re-registers with current labels. ## Files Changed - `k8s/infra/forgejo-runner/templates/deployment.yaml` (init container logic) ## After Merge ArgoCD syncs → deployment spec changes → pods restart → init re-registers with new labels from PR #1 → CI works across all repos.
rock added 1 commit 2026-09-07 05:26:08 +00:00
fix: always re-register runner to keep labels in sync with values.yaml 44d8e1e09d 
Init container skipped registration if .runner file existed on PVC.
Changing labels in values.yaml had no effect until PVC was manually
deleted — not GitOps-friendly.

Fix: rm -f .runner and re-register on every pod start.
rock force-pushed fix/ci-runners-and-dns from ad1ce5e4aa to 44d8e1e09d 2026-09-07 05:26:08 +00:00 Compare
rock changed title from fix: Forgejo CI runners + CoreDNS api.riotpiao.com rewrite to fix: always re-register runner to keep labels in sync 2026-09-07 05:26:16 +00:00
rock merged commit 326be2e057 into main 2026-09-07 05:27:32 +00:00
rock deleted branch fix/ci-runners-and-dns 2026-09-07 05:27:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
rock (Rock)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: rock/homelab#2