refactor(cnpg): adopt simple pattern - all apps use 'app' user
ARCHITECTURAL CHANGE: Align with CNPG design intent BEFORE (Complex, broken): - Per-app roles (authentik, temporal) with Database CR owner field - Database CR doesn't transfer ownership properly - Needed manual permission grants (PostSync Job) - Apps couldn't create tables without grants from 'app' role AFTER (Simple, works): - All apps use shared 'app' bootstrap user - Database CRs: owner: app (matches actual ownership) - No permission grants needed (owner has full rights) - Isolation via separate database names only CHANGES: - Database CRs: owner changed from app-specific to 'app' - ddb-cluster.yaml: removed managed.roles section - Deleted grant-schema-permissions PostSync Job - Follows Forgejo pattern (already working this way) MANUAL STEPS REQUIRED: 1. Update authentik-secrets: AUTHENTIK_POSTGRESQL__USER=app 2. Update temporal secrets: similar change 3. Recreate databases with app as owner 4. Restart applications Benefits: - Simpler architecture - No permission grant complexity - Aligns with CNPG single-cluster design - Matches working Forgejo implementation
This commit is contained in:
@@ -27,22 +27,10 @@ spec:
|
|||||||
- CREATE EXTENSION IF NOT EXISTS pgcrypto;
|
- CREATE EXTENSION IF NOT EXISTS pgcrypto;
|
||||||
- CREATE EXTENSION IF NOT EXISTS pg_trgm;
|
- CREATE EXTENSION IF NOT EXISTS pg_trgm;
|
||||||
|
|
||||||
# Per-app login roles, passwords sourced from secrets (CNPG reconciles the
|
# Simple ownership model: all apps use 'app' bootstrap user.
|
||||||
# role password to match the secret). Their databases are separate Database
|
# Isolation via separate database names, not separate roles.
|
||||||
# CRs (see authentik-database.yaml / temporal-database.yaml) owned by these
|
# Aligns with CNPG design (single cluster, multiple databases).
|
||||||
# roles. Replaces the old helmfile post-sync user-creation hook.
|
# managed.roles removed - no per-app roles needed.
|
||||||
managed:
|
|
||||||
roles:
|
|
||||||
- name: authentik
|
|
||||||
ensure: present
|
|
||||||
login: true
|
|
||||||
passwordSecret:
|
|
||||||
name: authentik-db-role
|
|
||||||
- name: temporal
|
|
||||||
ensure: present
|
|
||||||
login: true
|
|
||||||
passwordSecret:
|
|
||||||
name: temporal-db-role
|
|
||||||
|
|
||||||
# Disable superuser (security)
|
# Disable superuser (security)
|
||||||
enableSuperuserAccess: false
|
enableSuperuserAccess: false
|
||||||
|
|||||||
@@ -5,6 +5,6 @@ metadata:
|
|||||||
namespace: ddb
|
namespace: ddb
|
||||||
spec:
|
spec:
|
||||||
name: authentik
|
name: authentik
|
||||||
owner: authentik
|
owner: app # All apps use shared 'app' user (CNPG design pattern)
|
||||||
cluster:
|
cluster:
|
||||||
name: ddb-cluster
|
name: ddb-cluster
|
||||||
|
|||||||
@@ -1,122 +0,0 @@
|
|||||||
# PostSync Job to grant schema permissions after Database CRs reconcile
|
|
||||||
#
|
|
||||||
# ROOT CAUSE: CNPG Database CR creates databases but doesn't grant schema
|
|
||||||
# permissions to the specified owner role. The bootstrap database owner
|
|
||||||
# (app) retains CREATE privilege on public schema, blocking other roles.
|
|
||||||
#
|
|
||||||
# SOLUTION: After Database CRs reconcile, connect as 'app' (DB owner) and
|
|
||||||
# grant ALL on schema public to each Database's owner role.
|
|
||||||
#
|
|
||||||
# This runs every sync (BeforeHookCreation policy), ensuring permissions
|
|
||||||
# survive CNPG database recreation or cluster rebuilds.
|
|
||||||
apiVersion: v1
|
|
||||||
kind: ServiceAccount
|
|
||||||
metadata:
|
|
||||||
name: grant-schema-permissions
|
|
||||||
namespace: ddb
|
|
||||||
---
|
|
||||||
apiVersion: rbac.authorization.k8s.io/v1
|
|
||||||
kind: Role
|
|
||||||
metadata:
|
|
||||||
name: grant-schema-permissions
|
|
||||||
namespace: ddb
|
|
||||||
rules:
|
|
||||||
- apiGroups: [""]
|
|
||||||
resources: ["secrets"]
|
|
||||||
verbs: ["get"]
|
|
||||||
- apiGroups: ["postgresql.cnpg.io"]
|
|
||||||
resources: ["databases"]
|
|
||||||
verbs: ["list", "get"]
|
|
||||||
---
|
|
||||||
apiVersion: rbac.authorization.k8s.io/v1
|
|
||||||
kind: RoleBinding
|
|
||||||
metadata:
|
|
||||||
name: grant-schema-permissions
|
|
||||||
namespace: ddb
|
|
||||||
subjects:
|
|
||||||
- kind: ServiceAccount
|
|
||||||
name: grant-schema-permissions
|
|
||||||
namespace: ddb
|
|
||||||
roleRef:
|
|
||||||
kind: Role
|
|
||||||
name: grant-schema-permissions
|
|
||||||
apiGroup: rbac.authorization.k8s.io
|
|
||||||
---
|
|
||||||
apiVersion: batch/v1
|
|
||||||
kind: Job
|
|
||||||
metadata:
|
|
||||||
name: grant-schema-permissions
|
|
||||||
namespace: ddb
|
|
||||||
annotations:
|
|
||||||
argocd.argoproj.io/hook: PostSync
|
|
||||||
argocd.argoproj.io/hook-delete-policy: BeforeHookCreation
|
|
||||||
spec:
|
|
||||||
backoffLimit: 5
|
|
||||||
template:
|
|
||||||
spec:
|
|
||||||
serviceAccountName: grant-schema-permissions
|
|
||||||
restartPolicy: Never
|
|
||||||
containers:
|
|
||||||
- name: grant-permissions
|
|
||||||
image: postgres:16-alpine
|
|
||||||
command:
|
|
||||||
- /bin/sh
|
|
||||||
- -c
|
|
||||||
- |
|
|
||||||
set -e
|
|
||||||
|
|
||||||
echo "Granting schema permissions to database owners..."
|
|
||||||
|
|
||||||
# Get app user password (owns all databases)
|
|
||||||
export PGPASSWORD=$(cat /app-secret/password)
|
|
||||||
PGHOST=ddb-cluster-rw.ddb.svc.cluster.local
|
|
||||||
PGUSER=app
|
|
||||||
|
|
||||||
# Grant for authentik database
|
|
||||||
echo "Granting to authentik role in authentik database..."
|
|
||||||
psql -h "$PGHOST" -U "$PGUSER" -d authentik << 'SQL'
|
|
||||||
-- Database-level permission (needed for CREATE SCHEMA)
|
|
||||||
GRANT CREATE ON DATABASE authentik TO authentik;
|
|
||||||
-- Schema-level permissions
|
|
||||||
GRANT ALL ON SCHEMA public TO authentik;
|
|
||||||
GRANT ALL ON ALL TABLES IN SCHEMA public TO authentik;
|
|
||||||
GRANT ALL ON ALL SEQUENCES IN SCHEMA public TO authentik;
|
|
||||||
ALTER DEFAULT PRIVILEGES FOR ROLE app IN SCHEMA public GRANT ALL ON TABLES TO authentik;
|
|
||||||
ALTER DEFAULT PRIVILEGES FOR ROLE app IN SCHEMA public GRANT ALL ON SEQUENCES TO authentik;
|
|
||||||
SQL
|
|
||||||
|
|
||||||
# Grant for temporal database
|
|
||||||
echo "Granting to temporal role in temporal database..."
|
|
||||||
psql -h "$PGHOST" -U "$PGUSER" -d temporal << 'SQL'
|
|
||||||
-- Database-level permission
|
|
||||||
GRANT CREATE ON DATABASE temporal TO temporal;
|
|
||||||
-- Schema-level permissions
|
|
||||||
GRANT ALL ON SCHEMA public TO temporal;
|
|
||||||
GRANT ALL ON ALL TABLES IN SCHEMA public TO temporal;
|
|
||||||
GRANT ALL ON ALL SEQUENCES IN SCHEMA public TO temporal;
|
|
||||||
ALTER DEFAULT PRIVILEGES FOR ROLE app IN SCHEMA public GRANT ALL ON TABLES TO temporal;
|
|
||||||
ALTER DEFAULT PRIVILEGES FOR ROLE app IN SCHEMA public GRANT ALL ON SEQUENCES TO temporal;
|
|
||||||
SQL
|
|
||||||
|
|
||||||
# Grant for temporal_visibility database
|
|
||||||
echo "Granting to temporal role in temporal_visibility database..."
|
|
||||||
psql -h "$PGHOST" -U "$PGUSER" -d temporal_visibility << 'SQL'
|
|
||||||
-- Database-level permission
|
|
||||||
GRANT CREATE ON DATABASE temporal_visibility TO temporal;
|
|
||||||
-- Schema-level permissions
|
|
||||||
GRANT ALL ON SCHEMA public TO temporal;
|
|
||||||
GRANT ALL ON ALL TABLES IN SCHEMA public TO temporal;
|
|
||||||
GRANT ALL ON ALL SEQUENCES IN SCHEMA public TO temporal;
|
|
||||||
ALTER DEFAULT PRIVILEGES FOR ROLE app IN SCHEMA public GRANT ALL ON TABLES TO temporal;
|
|
||||||
ALTER DEFAULT PRIVILEGES FOR ROLE app IN SCHEMA public GRANT ALL ON SEQUENCES TO temporal;
|
|
||||||
SQL
|
|
||||||
|
|
||||||
echo "✅ Schema permissions granted successfully"
|
|
||||||
volumeMounts:
|
|
||||||
- name: app-secret
|
|
||||||
mountPath: /app-secret
|
|
||||||
readOnly: true
|
|
||||||
volumes:
|
|
||||||
- name: app-secret
|
|
||||||
secret:
|
|
||||||
secretName: ddb-cluster-app
|
|
||||||
@@ -8,7 +8,6 @@ namespace: ddb
|
|||||||
# GitOps-managed database schemas (ArgoCD wave 6).
|
# GitOps-managed database schemas (ArgoCD wave 6).
|
||||||
# These depend on ddb-cluster existing (bootstrap wave 0).
|
# These depend on ddb-cluster existing (bootstrap wave 0).
|
||||||
resources:
|
resources:
|
||||||
- grant-schema-permissions-job.yaml
|
|
||||||
- authentik-database.yaml
|
- authentik-database.yaml
|
||||||
- temporal-database.yaml
|
- temporal-database.yaml
|
||||||
- temporal-visibility-database.yaml
|
- temporal-visibility-database.yaml
|
||||||
|
|||||||
@@ -5,6 +5,6 @@ metadata:
|
|||||||
namespace: ddb
|
namespace: ddb
|
||||||
spec:
|
spec:
|
||||||
name: temporal
|
name: temporal
|
||||||
owner: temporal
|
owner: app # All apps use shared 'app' user (CNPG design pattern)
|
||||||
cluster:
|
cluster:
|
||||||
name: ddb-cluster
|
name: ddb-cluster
|
||||||
|
|||||||
@@ -5,6 +5,6 @@ metadata:
|
|||||||
namespace: ddb
|
namespace: ddb
|
||||||
spec:
|
spec:
|
||||||
name: temporal_visibility
|
name: temporal_visibility
|
||||||
owner: temporal
|
owner: app # All apps use shared 'app' user (CNPG design pattern)
|
||||||
cluster:
|
cluster:
|
||||||
name: ddb-cluster
|
name: ddb-cluster
|
||||||
|
|||||||
Reference in New Issue
Block a user