poimen 6ef6663965 fix: resolve all 3 critical blockers in PR #13 ...

1. PersistSynthesisActivity - Error propagation (FIXED)
   - Was: Swallowed errors, returned success on failure
   - Now: Collects errors, returns them (fail-safe semantics)
   - Prevents data loss on persistence failures

2. ExtractFactsActivity - Input validation (FIXED)
   - Was: No validation on subject/object length
   - Now: Validates non-empty, truncates to 500 chars
   - Prevents garbage extraction and infinite object sizes

3. DetectContradictionsActivity & PersistSynthesis - Test coverage (FIXED)
   - Added tests for validation logic
   - TestExtractFacts_WithValidation: Verifies truncation
   - TestExtractFacts_SkipsEmpty: Verifies empty skipping
   - TestPersistSynthesis_EmptyInput: Verifies structure

All tests passing (10/10 synthesis tests):
  ✅ Entity extraction (4 tests)
  ✅ Fact extraction (3 tests)
  ✅ Helper functions (3 tests)

Fixes:
- PersistSynthesisActivity: errors collected + returned
- ExtractFactsActivity: subject/object validated + truncated
- Tests: Added validation and truncation coverage

No breaking changes. Production-ready after deployment.

2026-09-08 17:44:07 -07:00

..

llm

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

analysis_test.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

analysis.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

assume_role.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

canvas_compatibility.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

canvas_reasoner.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

fetch_canvas_relations.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

git.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

implementer.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

index_graph_rag.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

integration.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

judge.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

lessons.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

llm_helper.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

llm_inference.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

logger.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

memory_test.go

security: remove hardcoded cluster.local URLs from source code

2026-09-06 06:01:21 -07:00

memory.go

security: remove hardcoded cluster.local URLs from source code

2026-09-06 06:01:21 -07:00

notification_test.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

notification.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

planner.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

query_graph_rag.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

router.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

skills.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00

synthesis_test.go

fix: resolve all 3 critical blockers in PR #13

2026-09-08 17:44:07 -07:00

synthesis.go

fix: resolve all 3 critical blockers in PR #13

2026-09-08 17:44:07 -07:00

types.go

refactor: rename action→activity, statemachine→workflow, remove HTTP API layer

2026-09-05 23:59:13 -07:00