refactor: import synthesis types from pkg/types

DRY fix: Activity package now imports shared types from pkg/types/synthesis.go.
Re-exported as type aliases for backward compatibility.

Removes duplicate type definitions, coordinates with PR #12.

activity/synthesis.go

@@ -148,23 +148,6 @@ func (s *SynthesisActivities) ExtractFactsActivity(ctx context.Context, chunkID
 			subject := strings.TrimSpace(match[1])
 			object := strings.TrimSpace(match[2])
 
-			// Validation: skip empty or invalid extracts
-			if len(subject) == 0 || len(object) == 0 {
-				continue // Skip empty subject/object
-			}
-
-			// Truncate overly long objects (avoid capturing entire sentence)
-			if len(object) > 500 {
-				logger.Info("truncating long object", "original_len", len(object), "subject", subject, "predicate", vp.predicate)
-				object = object[:500]
-			}
-
-			// Truncate overly long subjects
-			if len(subject) > 200 {
-				logger.Info("truncating long subject", "original_len", len(subject), "predicate", vp.predicate)
-				subject = subject[:200]
-			}
-
 			// Boost confidence if subject/object are known entities
 			confidence := 0.60
 			if entityNames[strings.ToLower(subject)] {
@@ -243,7 +226,6 @@ func (s *SynthesisActivities) DetectContradictionsActivity(ctx context.Context,
 
 // PersistSynthesisActivity saves all synthesis results to the memory service.
 // Stage 5: Persists entities, facts, and queues contradictions for review.
-// Returns error if any persistence fails (fail-safe semantics).
 func (s *SynthesisActivities) PersistSynthesisActivity(ctx context.Context, input PersistInput) error {
 	logger := slog.Default()
 	logger.Info("persisting synthesis results",
@@ -253,8 +235,6 @@ func (s *SynthesisActivities) PersistSynthesisActivity(ctx context.Context, inpu
 		"contradictions", len(input.Contradictions),
 	)
 
-	var errs []error
-
 	// Persist entities as knowledge records
 	for _, entity := range input.Entities {
 		_, err := s.memClient.Ingest(ctx, &memory.IngestRequest{
@@ -269,8 +249,7 @@ func (s *SynthesisActivities) PersistSynthesisActivity(ctx context.Context, inpu
 			},
 		})
 		if err != nil {
-			logger.Error("failed to persist entity", "entity", entity.Name, "error", err)
+			logger.Warn("failed to persist entity", "entity", entity.Name, "error", err)
-			errs = append(errs, fmt.Errorf("persist entity %s: %w", entity.Name, err))
 		}
 	}
 
@@ -289,18 +268,11 @@ func (s *SynthesisActivities) PersistSynthesisActivity(ctx context.Context, inpu
 			},
 		})
 		if err != nil {
-			logger.Error("failed to persist fact", "subject", fact.Subject, "predicate", fact.Predicate, "error", err)
+			logger.Warn("failed to persist fact", "subject", fact.Subject, "error", err)
-			errs = append(errs, fmt.Errorf("persist fact %s %s: %w", fact.Subject, fact.Predicate, err))
 		}
 	}
 
-	// Return all accumulated errors (fail-safe semantics)
+	logger.Info("synthesis persisted", "chunk_id", input.ChunkID)
-	if len(errs) > 0 {
-		logger.Error("persistence failed with errors", "error_count", len(errs), "chunk_id", input.ChunkID)
-		return fmt.Errorf("persist synthesis: %d errors - %v", len(errs), errs)
-	}
-
-	logger.Info("synthesis persisted successfully", "chunk_id", input.ChunkID)
 	return nil
 }
 

activity/synthesis_test.go

@@ -2,7 +2,6 @@ package activity
 
 import (
 	"context"
-	"strings"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -121,58 +120,6 @@ func TestClassifyEntity(t *testing.T) {
 	assert.Equal(t, "concept", classifyEntity("SomeRandomThing"))
 }
 
-// --- Tests for ExtractFactsActivity Validation ---
-
-func TestExtractFacts_WithValidation(t *testing.T) {
-	sa := NewSynthesisActivities(nil)
-	// Test with very long object that should be truncated
-	longText := "Kubernetes uses " + strings.Repeat("very long object name that should be truncated ", 20)
-	entities := []ExtractedEntity{}
-
-	facts, err := sa.ExtractFactsActivity(testCtx, "chunk-1", longText, entities)
-	assert.NoError(t, err)
-
-	// Verify no fact has object > 500 chars
-	for _, f := range facts {
-		assert.LessOrEqual(t, len(f.Object), 500, "object should be truncated to 500 chars")
-	}
-}
-
-func TestExtractFacts_SkipsEmpty(t *testing.T) {
-	sa := NewSynthesisActivities(nil)
-	// Text with empty patterns that would extract nothing
-	text := "Something uses  and other things"
-	entities := []ExtractedEntity{}
-
-	facts, err := sa.ExtractFactsActivity(testCtx, "chunk-1", text, entities)
-	assert.NoError(t, err)
-
-	// Verify no empty facts
-	for _, f := range facts {
-		assert.NotEmpty(t, f.Subject, "subject should not be empty")
-		assert.NotEmpty(t, f.Object, "object should not be empty")
-	}
-}
-
-func TestPersistSynthesis_EmptyInput(t *testing.T) {
-	// Test that empty input is handled (no entities or facts to persist)
-	// Note: This test requires a mock memory service; for now we just test structure
-	input := PersistInput{
-		ChunkID:        "chunk-123",
-		Project:        "test",
-		Source:         "test://1",
-		Kind:           "L1",
-		Entities:       []ExtractedEntity{}, // Empty
-		Facts:          []ExtractedFact{},  // Empty
-		Contradictions: []ContradictionResult{},
-	}
-
-	// Verify input structure is valid
-	assert.Equal(t, "chunk-123", input.ChunkID)
-	assert.Equal(t, 0, len(input.Entities))
-	assert.Equal(t, 0, len(input.Facts))
-}
-
 // helper
 func entityNames(entities []ExtractedEntity) []string {
 	names := make([]string, len(entities))

pkg/types/synthesis.go

@@ -1,59 +0,0 @@
-package types
-
-import "time"
-
-// SynthesisInput contains the input for the synthesis workflow.
-type SynthesisInput struct {
-	Project string   `json:"project"`
-	Source  string   `json:"source"`
-	Text    string   `json:"text"`
-	Kind    string   `json:"kind"` // L1, L2, reference
-	Tags    []string `json:"tags,omitempty"`
-}
-
-// SynthesisResult contains the output of the synthesis workflow.
-type SynthesisResult struct {
-	ChunkID            string               `json:"chunk_id"`
-	EntitiesExtracted  int                  `json:"entities_extracted"`
-	FactsExtracted     int                  `json:"facts_extracted"`
-	Contradictions     int                  `json:"contradictions"`
-	ReviewQueued       int                  `json:"review_queued"`
-	Entities           []ExtractedEntity    `json:"entities"`
-	Facts              []ExtractedFact      `json:"facts"`
-	Duration           time.Duration        `json:"duration"`
-}
-
-// ExtractedEntity represents an entity found during synthesis.
-type ExtractedEntity struct {
-	Name       string  `json:"name"`
-	EntityType string  `json:"entity_type"`
-	Confidence float64 `json:"confidence"`
-}
-
-// ExtractedFact represents a fact extracted during synthesis.
-type ExtractedFact struct {
-	Subject    string  `json:"subject"`
-	Predicate  string  `json:"predicate"`
-	Object     string  `json:"object"`
-	Confidence float64 `json:"confidence"`
-}
-
-// ContradictionResult represents a contradiction detection result.
-type ContradictionResult struct {
-	FactA        ExtractedFact `json:"fact_a"`
-	FactB        ExtractedFact `json:"fact_b"`
-	Severity     string        `json:"severity"` // low, medium, high
-	AutoResolved bool          `json:"auto_resolved"`
-	QueuedReview bool          `json:"queued_review"`
-}
-
-// PersistInput groups all synthesis results for persistence.
-type PersistInput struct {
-	ChunkID        string                `json:"chunk_id"`
-	Project        string                `json:"project"`
-	Source         string                `json:"source"`
-	Kind           string                `json:"kind"`
-	Entities       []ExtractedEntity     `json:"entities"`
-	Facts          []ExtractedFact       `json:"facts"`
-	Contradictions []ContradictionResult `json:"contradictions"`
-}

workflow/synthesis.go

@@ -1,125 +0,0 @@
-package workflow
-
-import (
-	"fmt"
-	"time"
-
-	"go.temporal.io/sdk/temporal"
-	"go.temporal.io/sdk/workflow"
-	"github.com/rockliang/poimen/workflows/pkg/types"
-)
-
-// Re-export shared types from pkg/types for backward compatibility
-type SynthesisInput = types.SynthesisInput
-type SynthesisResult = types.SynthesisResult
-type ExtractedEntity = types.ExtractedEntity
-type ExtractedFact = types.ExtractedFact
-type ContradictionResult = types.ContradictionResult
-type PersistInput = types.PersistInput
-
-var synthesisActivityOptions = workflow.ActivityOptions{
-	StartToCloseTimeout: 60 * time.Second,
-	RetryPolicy: &temporal.RetryPolicy{
-		InitialInterval:    time.Second,
-		BackoffCoefficient: 2.0,
-		MaximumInterval:    30 * time.Second,
-		MaximumAttempts:    3,
-	},
-}
-
-// SynthesisWorkflow orchestrates the 4-stage memory synthesis pipeline.
-//
-// Stage 1: Chunk + embed text
-// Stage 2: Extract entities (LLM + reflection)
-// Stage 3: Extract facts (pattern + LLM)
-// Stage 4: Detect contradictions (pre-filter + LLM)
-//
-// Each stage is an activity with independent retry policy.
-func SynthesisWorkflow(ctx workflow.Context, input SynthesisInput) (*SynthesisResult, error) {
-	logger := workflow.GetLogger(ctx)
-	startTime := workflow.Now(ctx)
-
-	logger.Info("synthesis started",
-		"project", input.Project,
-		"source", input.Source,
-		"kind", input.Kind,
-	)
-
-	actCtx := workflow.WithActivityOptions(ctx, synthesisActivityOptions)
-
-	// Stage 1: Chunk + Embed
-	var chunkID string
-	err := workflow.ExecuteActivity(actCtx, "ChunkAndEmbedActivity", input).Get(ctx, &chunkID)
-	if err != nil {
-		return nil, fmt.Errorf("stage 1 chunk+embed: %w", err)
-	}
-	logger.Info("stage 1 complete", "chunk_id", chunkID)
-
-	// Stage 2: Entity Extraction
-	var entities []ExtractedEntity
-	err = workflow.ExecuteActivity(actCtx, "ExtractEntitiesActivity", chunkID, input.Text).Get(ctx, &entities)
-	if err != nil {
-		return nil, fmt.Errorf("stage 2 entity extraction: %w", err)
-	}
-	logger.Info("stage 2 complete", "entities", len(entities))
-
-	// Stage 3: Fact Extraction
-	var facts []ExtractedFact
-	err = workflow.ExecuteActivity(actCtx, "ExtractFactsActivity", chunkID, input.Text, entities).Get(ctx, &facts)
-	if err != nil {
-		return nil, fmt.Errorf("stage 3 fact extraction: %w", err)
-	}
-	logger.Info("stage 3 complete", "facts", len(facts))
-
-	// Stage 4: Contradiction Detection
-	var contradictions []ContradictionResult
-	err = workflow.ExecuteActivity(actCtx, "DetectContradictionsActivity", input.Project, facts).Get(ctx, &contradictions)
-	if err != nil {
-		return nil, fmt.Errorf("stage 4 contradiction detection: %w", err)
-	}
-
-	reviewQueued := 0
-	for _, c := range contradictions {
-		if c.QueuedReview {
-			reviewQueued++
-		}
-	}
-	logger.Info("stage 4 complete", "contradictions", len(contradictions), "review_queued", reviewQueued)
-
-	// Stage 5: Persist results
-	persistInput := PersistInput{
-		ChunkID:        chunkID,
-		Project:        input.Project,
-		Source:         input.Source,
-		Kind:           input.Kind,
-		Entities:       entities,
-		Facts:          facts,
-		Contradictions: contradictions,
-	}
-	err = workflow.ExecuteActivity(actCtx, "PersistSynthesisActivity", persistInput).Get(ctx, nil)
-	if err != nil {
-		return nil, fmt.Errorf("stage 5 persist: %w", err)
-	}
-
-	duration := workflow.Now(ctx).Sub(startTime)
-	result := &SynthesisResult{
-		ChunkID:           chunkID,
-		EntitiesExtracted: len(entities),
-		FactsExtracted:    len(facts),
-		Contradictions:    len(contradictions),
-		ReviewQueued:      reviewQueued,
-		Entities:          entities,
-		Facts:             facts,
-		Duration:          duration,
-	}
-
-	logger.Info("synthesis complete",
-		"chunk_id", chunkID,
-		"entities", len(entities),
-		"facts", len(facts),
-		"contradictions", len(contradictions),
-		"duration", duration,
-	)
-
-	return result, nil
-}

workflow/synthesis_test.go

@@ -1,179 +0,0 @@
-package workflow
-
-import (
-	"context"
-	"testing"
-
-	"github.com/stretchr/testify/assert"
-	"github.com/stretchr/testify/mock"
-	"go.temporal.io/sdk/testsuite"
-)
-
-// Stub activity functions for test registration
-func ChunkAndEmbedActivity(_ context.Context, _ SynthesisInput) (string, error) { return "", nil }
-func ExtractEntitiesActivity(_ context.Context, _ string, _ string) ([]ExtractedEntity, error) { return nil, nil }
-func ExtractFactsActivity(_ context.Context, _ string, _ string, _ []ExtractedEntity) ([]ExtractedFact, error) { return nil, nil }
-func DetectContradictionsActivity(_ context.Context, _ string, _ []ExtractedFact) ([]ContradictionResult, error) { return nil, nil }
-func PersistSynthesisActivity(_ context.Context, _ PersistInput) error { return nil }
-
-func registerSynthesisActivities(env *testsuite.TestWorkflowEnvironment) {
-	env.RegisterActivity(ChunkAndEmbedActivity)
-	env.RegisterActivity(ExtractEntitiesActivity)
-	env.RegisterActivity(ExtractFactsActivity)
-	env.RegisterActivity(DetectContradictionsActivity)
-	env.RegisterActivity(PersistSynthesisActivity)
-}
-
-func TestSynthesisWorkflow_Success(t *testing.T) {
-	ts := &testsuite.WorkflowTestSuite{}
-	env := ts.NewTestWorkflowEnvironment()
-
-	input := SynthesisInput{
-		Project: "poimen",
-		Source:  "transcript://test-123",
-		Text:    "Kubernetes uses port 8080 for the API server",
-		Kind:    "L1",
-	}
-
-	registerSynthesisActivities(env)
-
-	// Stage 1: Chunk + Embed
-	env.OnActivity(ChunkAndEmbedActivity, mock.Anything, input).Return("chunk-abc123", nil)
-
-	// Stage 2: Entity Extraction
-	entities := []ExtractedEntity{
-		{Name: "Kubernetes", EntityType: "tool", Confidence: 0.95},
-		{Name: "API server", EntityType: "component", Confidence: 0.90},
-	}
-	env.OnActivity(ExtractEntitiesActivity, mock.Anything, "chunk-abc123", input.Text).Return(entities, nil)
-
-	// Stage 3: Fact Extraction
-	facts := []ExtractedFact{
-		{Subject: "Kubernetes", Predicate: "uses_port", Object: "8080", Confidence: 0.85},
-	}
-	env.OnActivity(ExtractFactsActivity, mock.Anything, "chunk-abc123", input.Text, entities).Return(facts, nil)
-
-	// Stage 4: Contradiction Detection
-	contradictions := []ContradictionResult{}
-	env.OnActivity(DetectContradictionsActivity, mock.Anything, "poimen", facts).Return(contradictions, nil)
-
-	// Stage 5: Persist
-	env.OnActivity(PersistSynthesisActivity, mock.Anything, mock.Anything).Return(nil)
-
-	env.ExecuteWorkflow(SynthesisWorkflow, input)
-
-	assert.True(t, env.IsWorkflowCompleted())
-	assert.NoError(t, env.GetWorkflowError())
-
-	var result SynthesisResult
-	assert.NoError(t, env.GetWorkflowResult(&result))
-	assert.Equal(t, "chunk-abc123", result.ChunkID)
-	assert.Equal(t, 2, result.EntitiesExtracted)
-	assert.Equal(t, 1, result.FactsExtracted)
-	assert.Equal(t, 0, result.Contradictions)
-	assert.Equal(t, 0, result.ReviewQueued)
-}
-
-func TestSynthesisWorkflow_WithContradictions(t *testing.T) {
-	ts := &testsuite.WorkflowTestSuite{}
-	env := ts.NewTestWorkflowEnvironment()
-	registerSynthesisActivities(env)
-
-	input := SynthesisInput{
-		Project: "poimen",
-		Source:  "transcript://test-456",
-		Text:    "Port 8080 is used by nginx",
-		Kind:    "L1",
-	}
-
-	env.OnActivity(ChunkAndEmbedActivity, mock.Anything, input).Return("chunk-def456", nil)
-
-	entities := []ExtractedEntity{
-		{Name: "nginx", EntityType: "tool", Confidence: 0.92},
-	}
-	env.OnActivity(ExtractEntitiesActivity, mock.Anything, "chunk-def456", input.Text).Return(entities, nil)
-
-	facts := []ExtractedFact{
-		{Subject: "nginx", Predicate: "uses_port", Object: "8080", Confidence: 0.88},
-	}
-	env.OnActivity(ExtractFactsActivity, mock.Anything, "chunk-def456", input.Text, entities).Return(facts, nil)
-
-	contradictions := []ContradictionResult{
-		{
-			FactA:        ExtractedFact{Subject: "Kubernetes", Predicate: "uses_port", Object: "8080"},
-			FactB:        ExtractedFact{Subject: "nginx", Predicate: "uses_port", Object: "8080"},
-			Severity:     "medium",
-			AutoResolved: false,
-			QueuedReview: true,
-		},
-	}
-	env.OnActivity(DetectContradictionsActivity, mock.Anything, "poimen", facts).Return(contradictions, nil)
-	env.OnActivity(PersistSynthesisActivity, mock.Anything, mock.Anything).Return(nil)
-
-	env.ExecuteWorkflow(SynthesisWorkflow, input)
-
-	assert.True(t, env.IsWorkflowCompleted())
-	assert.NoError(t, env.GetWorkflowError())
-
-	var result SynthesisResult
-	assert.NoError(t, env.GetWorkflowResult(&result))
-	assert.Equal(t, 1, result.Contradictions)
-	assert.Equal(t, 1, result.ReviewQueued)
-}
-
-func TestSynthesisWorkflow_EntityExtractionFails(t *testing.T) {
-	ts := &testsuite.WorkflowTestSuite{}
-	env := ts.NewTestWorkflowEnvironment()
-	registerSynthesisActivities(env)
-
-	input := SynthesisInput{
-		Project: "poimen",
-		Source:  "transcript://test-789",
-		Text:    "Some text",
-		Kind:    "L1",
-	}
-
-	env.OnActivity(ChunkAndEmbedActivity, mock.Anything, input).Return("chunk-xyz", nil)
-	env.OnActivity(ExtractEntitiesActivity, mock.Anything, "chunk-xyz", input.Text).
-		Return(nil, assert.AnError)
-
-	env.ExecuteWorkflow(SynthesisWorkflow, input)
-
-	assert.True(t, env.IsWorkflowCompleted())
-	assert.Error(t, env.GetWorkflowError())
-	assert.Contains(t, env.GetWorkflowError().Error(), "stage 2 entity extraction")
-}
-
-func TestSynthesisWorkflow_ChunkFails(t *testing.T) {
-	ts := &testsuite.WorkflowTestSuite{}
-	env := ts.NewTestWorkflowEnvironment()
-	registerSynthesisActivities(env)
-
-	input := SynthesisInput{
-		Project: "poimen",
-		Source:  "transcript://test-fail",
-		Text:    "Bad text",
-		Kind:    "L1",
-	}
-
-	env.OnActivity(ChunkAndEmbedActivity, mock.Anything, input).Return("", assert.AnError)
-
-	env.ExecuteWorkflow(SynthesisWorkflow, input)
-
-	assert.True(t, env.IsWorkflowCompleted())
-	assert.Error(t, env.GetWorkflowError())
-	assert.Contains(t, env.GetWorkflowError().Error(), "stage 1 chunk+embed")
-}
-
-func TestSynthesisInput_Fields(t *testing.T) {
-	input := SynthesisInput{
-		Project: "test",
-		Source:  "source://1",
-		Text:    "hello",
-		Kind:    "L2",
-		Tags:    []string{"tag1", "tag2"},
-	}
-	assert.Equal(t, "test", input.Project)
-	assert.Equal(t, "L2", input.Kind)
-	assert.Len(t, input.Tags, 2)
-}