feat: improve knowledge_base.go with embedded file loading, singleton pattern, and CRAP analysis

Browse Source

Changes:
- Added embedded file loading (go:embed) for activity_knowledge_base.json
  - DRY: No external file dependency, loads from binary
  - SOLID: Single source of truth

- Added singleton pattern with sync.Once
  - GetGlobalKnowledgeBase() lazy-loads KB once
  - Thread-safe access to global instance

- Comprehensive CRAP analysis comments
  - Identified CRAP scores for each method
  - Documented complexity and repetition assessment

- DRY principle improvements
  - byName index for O(1) lookup (avoids repeated linear scans)
  - Consolidated logic, identified single responsibilities

- SOLID principle application
  - Single Responsibility: Each method has one clear purpose
  - Open/Closed: Easy to extend with new activity types/categories
  - Dependency Inversion: Depends on interfaces, not concrete file paths

Methods analyzed:
- LoadKnowledgeBase: CRAP=2 (excellent)
- loadKnowledgeBaseFromEmbedded: CRAP=2 (excellent)
- GetGlobalKnowledgeBase: CRAP=2 (excellent)
- GetActivity: CRAP=2 (excellent)
- ListActivitiesByCategory: CRAP=2 (excellent)
- HasActivity: CRAP=2 (excellent)
- GetRetryPolicyForActivity: CRAP=3 (good)
- Validate: CRAP=5 (acceptable for graph validation)
- checkDependencies: CRAP=4 (acceptable for DFS)

All existing tests pass. No breaking changes.

...

This commit is contained in:

Test

2026-09-08 15:59:01 -07:00

parent e15a535d82

commit ff444e3902

2 changed files with 170 additions and 21 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

poimen-worker

BIN

Binary file not shown.