8 Commits

Include renames

Author	SHA1	Message	Date
rock	3f83c1b015	refactor: complete SOLID fixes + RAII guards + enhanced test assertions ... ISP (Interface Segregation Principle): - Add JobStatusStore trait for database persistence - Implement PgJobStatusStore for PostgreSQL - Add MockJobStatusStore for unit testing - IngestWorker::with_job_store() enables dependency injection - Job status updates now via trait (testable, mockable) Resource Management (RAII): - Add PortForwardGuard struct with Drop impl - Ensures port-forward process killed even if test panics - Prevents resource leaks in integration tests Test Assertions (Verification): - Enhanced unit tests verify entity names, not just counts - Verify edges connect correct entity pairs - Verify both source and target entities exist - Batch processing verifies expected entities extracted - Entity deduplication test across multiple records All 9 issues now fixed: ✅ DRY: Removed wrapper function ✅ CRAP: Extracted save_*_with_logging() helpers ✅ OCP: Added JobStatus enum ✅ SRP: Real-time logging, no error accumulation ✅ ISP: JobStatusStore trait + mocking ✅ Logging: IngestLogContext struct ✅ RAII: PortForwardGuard for cleanup ✅ Error handling: Real-time logging at point of failure ✅ Test assertions: Verify names + connections Verification: cargo check -p mem-cli ✓	2026-09-15 13:30:19 +09:00
rock	53761b50d5	refactor: ingest_worker CRAP/DRY/SOLID fixes (code review PR #55) ... - Fix DRY: Remove process_ingest() wrapper, single public fn - Fix CRAP: Extract save_entity_with_logging() and save_edge_with_logging() helpers - Reduce cyclomatic complexity from 12+ to 4 - Enable isolated testing of save operations - Fix OCP: Replace magic status strings with enum JobStatus - Type-safe alternatives (processing|done|done_with_errors) - Catches typos at compile-time - Fix SRP: Remove error accumulation Vecs, use real-time logging - Errors logged immediately at point of failure - Worker now owns: job status tracking + persistence only - Makes worker testable without database mocks - Add IngestLogContext struct for consistent structured logging - Ensures field names consistent across all logs - Enables log schema validation + observability aggregation ISP violation (JobStatusStore trait) deferred to next PR (non-blocking). Test improvements (resource cleanup, assertions) deferred (minor). Verification: cargo check -p mem-cli ✓	2026-09-15 13:27:47 +09:00
rock	db79ea8ffd	feat: complete X-Forward-User auth integration for LLM extraction ... Full auth chain for entity extraction via api.riotpiao.com: 1. HTTP request → ingest_handler captures X-Forward-User header 2. Passes to execute_ingest → spawn worker with x_forward_user param 3. Worker calls process_ingest_with_auth → passes to pipeline 4. Pipeline.ingest_with_auth → passes to extractor 5. LlmEntityExtractor.extract_with_auth → calls LLM with auth Auth priority (per API Gateway spec): 1. X-Forward-User header (API Gateway passthrough) 2. Authentik JWT via jwt_issuer (service account) 3. LLM_API_KEY env var (fallback) Error handling: ✓ HTTP 403 JWT validation failed → returns error (not empty array) ✓ LLM extraction failures logged with full context ✓ Graceful fallback to mock response on explicit error Integration with homelab-frontend/API.md: ✓ Supports Bearer token auth (Authentik JWT) ✓ Supports X-Forward-User header (gateway pattern) ✓ Proper error responses (RFC 9457 problem details) ✓ No more silent failures (403 errors now propagate) Next: Deploy to K8s with proper JWT secrets Test with actual X-Forward-User from gateway Monitor LLM extraction success rate	2026-09-14 23:49:27 +09:00
rock	6915dc2462	feat: production ingest test suite with detailed logging ... Add comprehensive E2E test scripts and logging for production testing: - test_prod_ingest_real.sh: Full ingest test against K8s cluster with api-gw - apply_migrations.sh: Manual database schema migration (backup method) - collect_prod_logs.sh: Pod log collection before/after tests - run_production_test.sh: Orchestrates full test + log collection - tests/integration_ingest_with_gw.rs: Integration test with embeddings - tests/unit_ingest_logging.rs: Unit tests for extraction pipeline Enhanced logging in ingest_worker.rs: - Per-record event tracking (extraction, save) - Entity and edge operation logging - Error accumulation and reporting - Structured logging for observability Production testing identified root cause: - Ingest + embedding pipeline working correctly - Entity extraction functional - Database schema missing (migration not applied) - Logs clearly show: relation "memory_entity" does not exist Next: Trigger DB Migration workflow in Forgejo Actions to apply crates/mem-store/migrations/*.sql files.	2026-09-14 22:33:16 +09:00
poimenandrock	fb61de6b47	feat: LLM entity + fact extraction pipeline (Zep paper alignment) (#48) ... ## Changes ### Entity Extraction - Switch from WikiLinkFallbackExtractor to LlmEntityExtractor when LLM_ENDPOINT set - `clean_llm_response()`: strips `<think>` tags, markdown fences, extracts JSON - Handle array responses (Ollama returns `[...]` not `{entities: [...]}`) - EntityType custom Deserialize: unknown variants → Unknown (no crash) - Increase timeout 30s→90s, max_tokens 500→1500 for reasoning models - Graceful reflection fallback: keep entities if verification fails ### Fact Extraction (NEW) - LlmFactExtractor: LLM-based relationship extraction between entity pairs - Validates source/target against known entity list (drops hallucinated edges) - Same robust JSON cleaning for reasoning models + Ollama - IngestWorker auto-selects LLM vs Simple based on LLM_ENDPOINT env ### K8s Deployment - Add `command: ["/app/mem"]` (fix args replacing CMD) - Add LLM_ENDPOINT, LLM_MODEL env vars for in-cluster LLM ## E2E Tested (local Ollama qwen2.5:3b) - 12 entities extracted (person, tool, concept, organization) - 5 edges with relationships and facts - 781 tests pass ## Zep Paper Alignment (§2.2) - Entity extraction + resolution (§2.2.1) - Fact extraction between entity pairs (§2.2.2) - Temporal edge invalidation ready (t_valid/t_invalid schema) - Reflection verification (§2.2.1, graceful fallback) --------- Co-authored-by: rock <[email protected]> Reviewed-on: #48 Co-authored-by: poimen <[email protected]>	2026-09-11 01:11:15 +00:00
rock	1e5c3d1433	feat: setup phase 3 agent infrastructure + enable docker ci on prs ... - Enable docker build, sha extraction on PRs (validate Dockerfile) - Add SOPS encrypted memory-agent credentials - Plan 15 tasks: 5 memory service + 10 temporal workflow - Milestone: monitoring-agent (due 2025-03-15) - Ready: Forgejo API token needed for PR automation ``` Co-authored-by: rock <[email protected]>	2026-09-08 23:16:31 +00:00
Story Crater Bot	8e8bf92591	feat: M3.7.7 complete — failure signature extraction (18 unit tests passing, CLI cmd_sig added, fixtures created)	2026-08-28 07:47:26 -07:00
rock	af6f22217d	feat(core): implement full memory pipeline (#11)	2026-08-24 01:37:16 +00:00