fix(comfyui): keep the login path on an ungated ingress

Gating /oauth2 with the app redirects /oauth2/start to itself and the browser
loops. ingress-nginx applies an ingress's annotations to the locations that
ingress defines, so the login path belongs on its own object without auth-url.

This split failed once before, and the split was not the reason: the app ingress
carried a configuration-snippet that the controller rejects, which dropped that
whole object and left only the login path rendered.
This commit was merged in pull request #83.
This commit is contained in:
2026-10-27 14:26:49 -07:00
parent 056964075e
commit 2485b5f165
2 changed files with 25 additions and 12 deletions
-12
View File
@@ -29,18 +29,6 @@ spec:
- host: comfyui.riotpiao.com - host: comfyui.riotpiao.com
http: http:
paths: paths:
# The login path lives on the SAME ingress as the app. Two Ingresses on
# one host do not merge their annotations: nginx applies the annotations
# of a single ingress per host, so a separate /oauth2 object silently
# dropped the auth_request above and every request fell through to the
# backend, which answered 404.
- path: /oauth2
pathType: Prefix
backend:
service:
name: comfyui-oauth2-proxy
port:
number: 4180
- path: / - path: /
pathType: Prefix pathType: Prefix
backend: backend:
+25
View File
@@ -78,3 +78,28 @@ spec:
app: comfyui-oauth2-proxy app: comfyui-oauth2-proxy
ports: ports:
- {name: http, port: 4180, targetPort: http} - {name: http, port: 4180, targetPort: http}
---
# The login path must NOT be gated: a request to /oauth2/start that itself demands a
# login redirects to /oauth2/start forever. ingress-nginx applies the annotations of
# an ingress to the locations it defines, so a separate object without auth-url keeps
# this path open. The earlier failure of this shape was not the split — it was the
# configuration-snippet on the app ingress, which made the controller drop the whole
# object and left only this one alive.
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: comfyui-oauth2
namespace: comfyui
spec:
ingressClassName: nginx
rules:
- host: comfyui.riotpiao.com
http:
paths:
- path: /oauth2
pathType: Prefix
backend:
service:
name: comfyui-oauth2-proxy
port:
number: 4180